fix(a11y): restore business-group color radiogroup contract - #901
fix(a11y): restore business-group color radiogroup contract#901cursor[bot] wants to merge 16 commits into
Conversation
💡 What: Changed the custom color swatches in GroupModal to use `role="radio"` and `aria-checked` instead of `aria-pressed`. Updated the corresponding test queries. 🎯 Why: Elements inside a `role="radiogroup"` must use `role="radio"` to be properly understood by screen readers as a group of mutually exclusive options. Using generic buttons with `aria-pressed` inside a radiogroup creates mismatched structural semantics. ♿ Accessibility: Improved screen reader navigation and state announcement for the business group color selection. 📸 Before/After: Visuals are unchanged; screen readers now announce "radio, checked" instead of "button, pressed".
💡 What: `GroupModal`의 색상 스와치 선택 인터페이스에 WAI-ARIA Radio Group Pattern을 완전하게 구현했습니다. Roving tabindex 로직, Arrow 키(상하좌우) 순환 포커스 및 `aria-checked`의 단일 활성 상태를 보장하도록 추가하고 CSS를 동기화했습니다. 관련된 상호작용 검증 테스트 케이스들을 추가했습니다. 🎯 Why: 기존 `aria-checked` 수정 후 `<button>` 요소들이 탭 시퀀스에 모두 노출되고 키보드 내비게이션(방향키 등)을 지원하지 않아 화면 판독기 사용자가 그룹을 정상적으로 탐색하고 선택할 수 없었습니다. ♿ Accessibility: W3C 접근성 권장 사항을 충족하여 키보드 전용 사용자들도 색상 스와치를 직관적으로 탐색 및 선택할 수 있게 되었습니다.
💡 What: `GroupModal`의 색상 스와치 선택 인터페이스에 WAI-ARIA Radio Group Pattern을 완전하게 구현했습니다. 추가로, 그룹 삭제 확인 창(`window.confirm`)의 Template Injection(SyntaxError) 취약점을 문자열 연결 방식으로 수정했습니다. 🎯 Why: 기존 `<button>` 요소들이 탭 시퀀스에 노출되고 키보드 내비게이션을 지원하지 않아 화면 판독기 접근성이 떨어졌습니다. 또한 템플릿 리터럴로 인한 잠재적 STRIX 보안 스캔 실패를 사전 차단했습니다. ♿ Accessibility: W3C 권장 사항을 충족하여 키보드 전용 사용자들도 색상 스와치를 Arrow key로 손쉽게 탐색 및 선택할 수 있게 되었습니다.
💡 What: `GroupModal`의 색상 스와치 선택 인터페이스에 WAI-ARIA Radio Group Pattern을 완전하게 구현했습니다. 추가로 jsdom 환경의 테스트 안정성을 위해 속성 검증 로직을 개선했습니다. 🎯 Why: 기존 `<button>` 요소들이 탭 시퀀스에 노출되고 키보드 내비게이션을 지원하지 않아 화면 판독기 접근성이 떨어졌습니다. ♿ Accessibility: W3C 권장 사항을 충족하여 키보드 전용 사용자들도 색상 스와치를 Arrow key로 손쉽게 탐색 및 선택할 수 있게 되었습니다.
664757a deleted the focused radiogroup regression, doctoring record, and component-local selected-state CSS. Restore that contract and add Tab-from-name, Space activation, exact aria-checked, and WAI-ARIA 1.3 APA 7 coverage requested by current-head review. Co-authored-by: Seongho Bae <[email protected]>
![opencode-agent[bot]](https://avatars.githubusercontent.com/in/1549082?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request overview
OpenCode cannot approve yet because required coverage evidence did not pass.
Review outcome
1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
-
Problem: The required coverage-evidence job result was
failure, so OpenCode cannot establish approval sufficiency for this head. -
Root cause: Automated approval is only valid when the same-head coverage-evidence job proves supported repository test suites passed and configured docstring gates passed or were advisory, or reports not applicable because no supported source files or package manifests exist. Missing, failed, skipped, unavailable, or unsupported-tooling test evidence is a blocker.
-
Fix: Install or configure the repository test/docstring evidence tooling when source files or package manifests exist, rerun the current-head coverage-evidence job, and approve only after it reports
successwith required evidence or explicit no-source not-applicable evidence. -
Regression test: Keep the approval branch checking
needs.coverage-evidence.result == successbefore posting APPROVE, and publish REQUEST_CHANGES when coverage-evidence blocker states such as cancelled, skipped, failed, unsupported-tooling, or below-100 evidence are present. -
Result: REQUEST_CHANGES
-
Reason: coverage-evidence result was
failure, so required test/docstring evidence was not proven for current heade65b28e94959060eaf77af39c7da2d5a3c2cbeba. -
Head SHA:
e65b28e94959060eaf77af39c7da2d5a3c2cbeba -
Workflow run: 32160963627
-
Workflow attempt: 1
Coverage evidence
Coverage Decision
- Result: FAIL
- Test evidence: not proven passing
- Docstring evidence: not proven passing when configured
- Failure count: 1
Changed-File Evidence Map
flowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Changed file: CHANGELOG.md"]
S1 --> I1["repository behavior"]
I1 --> R1["Review risk: Changed file: CHANGELOG.md"]
R1 --> V1["required checks"]
Evidence --> S2["Docs: group-color-radiogroup-keyboard.md"]
S2 --> I2["operator or user guidance"]
I2 --> R2["Review risk: Docs: group-color-radiogroup-keyboard.md"]
R2 --> V2["docs review"]
Evidence --> S3["Frontend (6 files)"]
S3 --> I3["browser runtime and bundle"]
I3 --> R3["Review risk: Frontend (6 files)"]
R3 --> V3["frontend tests"]
|
@OpenCode review |
|
@opencode-agent review |
|
Queued @opencode-agent for PR #901 at head |
|
Already queued @opencode-agent on this exact request for PR #901 at head |
1 similar comment
|
Already queued @opencode-agent on this exact request for PR #901 at head |
|
Already queued @opencode-agent on this exact request for PR #901 at head |
|
Queued @opencode-agent for PR #901 at head |
|
Already queued @opencode-agent on this exact request for PR #901 at head |
2 participants
Buyer-visible gap
PR #893 head
664757afdeleted the focused radiogroup regression, the doctoring record, and the component-local selected-state CSS, then replaced them with a looser monolithic test. Keyboard users still need one Tab stop, wrapping arrow-key selection, and a visible checked ring.Current change
radiogroup/radio/aria-checkedcontract with rovingtabIndex;GroupModal.cssusing the--color-text-strongtoken;aria-checked="true", and.groupManager__swatch[aria-checked="true"];Verification
npm run test -- src/components/modals/GroupModal.radiogroup.test.tsx src/components/modals/GroupModal.test.tsx src/components/modals/ModalCoverage.test.tsx src/components/modals/DialogAccessibility.test.tsx— 24 passed.Relationship to #893
This branch starts from #893 head and restores the
7cd2a919/44087a18evidence that664757afremoved, then adds the remaining review contracts. Prefer this PR for merge once exact-head checks are green.