Skip to content

test(api): verify the authenticated project-list contract - #890

Open
seonghobae wants to merge 3 commits into
mainfrom
test/project-list-endpoint-contract-20260815
Open

test(api): verify the authenticated project-list contract#890
seonghobae wants to merge 3 commits into
mainfrom
test/project-list-endpoint-contract-20260815

Conversation

@seonghobae

Copy link
Copy Markdown
Collaborator

Outcome

Adds a clean current-main integration regression for GET /api/projects through FastAPI's public routing and dependency-injection boundary.

Contract

  • an authenticated user with no memberships receives an empty list;
  • populated database results are projected in returned order with exact UUID and name values;
  • the route executes exactly one read statement;
  • every test application, authentication override, and session fake is isolated to the test invocation;
  • production code, dependencies, database objects, workflows, and runtime behavior are unchanged.

Scope

Exactly one new backend test file with typed, documented SQLAlchemy result/session fakes and deterministic UUID/timestamp fixtures.

Supersedes stale PR #826, whose module-global FastAPI app and persistent dependency overrides could leak state across tests.

Merge boundary

Merge only after the unchanged exact head passes every required CI, coverage, security, supply-chain, Strix, and OpenCode context; no actionable review thread remains; and any policy-required qualifying independent approval is present.

@coderabbitai

coderabbitai Bot commented Aug 15, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 41 minutes

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

Wait for the limit to reset, then comment @coderabbitai review or push new commits to the PR.

An organization admin can change what happens after included review limits in Billing.

How do review limits work?

CodeRabbit enforces per-developer PR review limits within each organization.

For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: d8545489-6c5e-4c6a-9cdb-527b24d7684e

📥 Commits

Reviewing files that changed from the base of the PR and between 729eacc and a04935d.

📒 Files selected for processing (1)
  • backend/tests/test_api_projects.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@opencode-agent opencode-agent Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

OpenCode cannot approve yet because required coverage evidence did not pass.

Review outcome

1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence

  • Problem: The required coverage-evidence job result was failure, so OpenCode cannot establish approval sufficiency for this head.

  • Root cause: Automated approval is only valid when the same-head coverage-evidence job proves supported repository test suites passed and configured docstring gates passed or were advisory, or reports not applicable because no supported source files or package manifests exist. Missing, failed, skipped, unavailable, or unsupported-tooling test evidence is a blocker.

  • Fix: Install or configure the repository test/docstring evidence tooling when source files or package manifests exist, rerun the current-head coverage-evidence job, and approve only after it reports success with required evidence or explicit no-source not-applicable evidence.

  • Regression test: Keep the approval branch checking needs.coverage-evidence.result == success before posting APPROVE, and publish REQUEST_CHANGES when coverage-evidence blocker states such as cancelled, skipped, failed, unsupported-tooling, or below-100 evidence are present.

  • Result: REQUEST_CHANGES

  • Reason: coverage-evidence result was failure, so required test/docstring evidence was not proven for current head 7c13034c66d1c9245fd1d89182f4020080db1a84.

  • Head SHA: 7c13034c66d1c9245fd1d89182f4020080db1a84

  • Workflow run: 32122838055

  • Workflow attempt: 1

Coverage evidence

Coverage Decision

  • Result: FAIL
  • Test evidence: not proven passing
  • Docstring evidence: not proven passing when configured
  • Failure count: 1

Changed-File Evidence Map

flowchart LR
  PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
  Evidence --> S1["Backend: test_api_projects.py"]
  S1 --> I1["API and service runtime"]
  I1 --> R1["Review risk: Backend: test_api_projects.py"]
  R1 --> V1["backend tests"]
Loading

@opencode-agent

Copy link
Copy Markdown
Contributor

OpenCode Review Overview

  • Head SHA: 7c13034c66d1c9245fd1d89182f4020080db1a84
  • Workflow run: 32122838055
  • Workflow attempt: 1
  • Gate result: REQUEST_CHANGES (approval step)

Pull request overview

OpenCode cannot approve yet because required coverage evidence did not pass.

Review outcome

1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence

  • Problem: The required coverage-evidence job result was failure, so OpenCode cannot establish approval sufficiency for this head.

  • Root cause: Automated approval is only valid when the same-head coverage-evidence job proves supported repository test suites passed and configured docstring gates passed or were advisory, or reports not applicable because no supported source files or package manifests exist. Missing, failed, skipped, unavailable, or unsupported-tooling test evidence is a blocker.

  • Fix: Install or configure the repository test/docstring evidence tooling when source files or package manifests exist, rerun the current-head coverage-evidence job, and approve only after it reports success with required evidence or explicit no-source not-applicable evidence.

  • Regression test: Keep the approval branch checking needs.coverage-evidence.result == success before posting APPROVE, and publish REQUEST_CHANGES when coverage-evidence blocker states such as cancelled, skipped, failed, unsupported-tooling, or below-100 evidence are present.

  • Result: REQUEST_CHANGES

  • Reason: coverage-evidence result was failure, so required test/docstring evidence was not proven for current head 7c13034c66d1c9245fd1d89182f4020080db1a84.

  • Head SHA: 7c13034c66d1c9245fd1d89182f4020080db1a84

  • Workflow run: 32122838055

  • Workflow attempt: 1

Coverage evidence

Coverage Decision

  • Result: FAIL
  • Test evidence: not proven passing
  • Docstring evidence: not proven passing when configured
  • Failure count: 1

Changed-File Evidence Map

flowchart LR
  PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
  Evidence --> S1["Backend: test_api_projects.py"]
  S1 --> I1["API and service runtime"]
  I1 --> R1["Review risk: Backend: test_api_projects.py"]
  R1 --> V1["backend tests"]
Loading

@opencode-agent
opencode-agent Bot disabled auto-merge August 18, 2026 10:41
@seonghobae
seonghobae enabled auto-merge August 20, 2026 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant