fix(security): fail closed on hostile clipboard throw values - #351
Draft
seonghobae wants to merge 6 commits into
Draft
fix(security): fail closed on hostile clipboard throw values#351seonghobae wants to merge 6 commits into
seonghobae wants to merge 6 commits into
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Test-first repair for #349 on the deterministic local SafeClipboard adapter boundary only. No transport, persistence, auth, tenancy, credential, model/provider, network, deployment, retention, durable-audit, or clipboard-exfiltration authority is added.
Current state: hosted RED pending
main@e8109ec2a17de8bd6594487aa12c8c8a93cb2c03.758c36c05f104be0cc6b608acd5c753ea5b9b709.transformPastedHTMLadapter with a hostconfiggetter that throws a Proxy whosegetPrototypeOftrap throws a private sentinel.instanceof, so the expected hosted failure is the private sentinel escaping instead of''plus a stable redactedinvalid_htmlerror.Production code is intentionally unchanged until exact-head hosted RED is observed. After RED, the smallest repair will replace prototype inspection with a side-effect-free module-owned brand/check for genuine
ClipboardSanitizationErrorvalues and normalize every other thrown value without inspecting it.Integration boundary
Keep Draft/unmerged while #118 owns the unchanged exact protected
v0.6.0publication source identity.Refs #349