fix(supply-chain): exclude Docker build-context secrets - #295
Draft
seonghobae wants to merge 4 commits into
Draft
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #294.
Exact TDD lineage
This Draft started from protected
main@e8109ec2a17de8bd6594487aa12c8c8a93cb2c03and owns only.dockerignoreplussrc/dockerBuildContextSecurity.test.ts.Test-only head
8ba8711dedcc2d85ee8fca451f53fd1fa16783a9produced qualifying hosted RED in CI31653842186, build job94303775209: exact-head checkout, immutable install, and typecheck completed before the new contract failed exactly because protected.dockerignore@7181b19c91919c189498bf5c7b4db9ff11c32866did not exclude.envor private-key material. Browser and Office lanes remained green. Security Scan31653842335succeeded. SAST31653842248also identified a valid dynamic-RegExp defect in the first test helper; that finding was fixed rather than suppressed.Current narrow repair
Current exact head is
6e3d1722b5e44470d6b249cb4b1cbad8578f1396against live basemain@e8109ec2a17de8bd6594487aa12c8c8a93cb2c03.The build context now recursively excludes local
.env*, npm/pnpm/yarn/netrc credential files, and common PEM/KEY/PKCS#12 credential containers, with an ordered negation that keeps deliberate.env.examplefiles available. The contract uses deterministic wildcard matching rather than runtime-generated regular expressions and proves required package, lock, source, style, and demo inputs remain in context. Inkspan's standalone build remains credential-free; no Docker ARG/ENV secret, secret mount, network requirement, database, model, or host-owned deployment authority was introduced.Exact-head proof
For unchanged head
6e3d1722b5e44470d6b249cb4b1cbad8578f1396:31654551840: success. Exact checkout, immutable install, typecheck, 144 test files / 830 tests, and exact 100% owned-production statement/branch/function/line coverage passed.31654551829: success.31654551844: success. The predecessor dynamic-RegExp thread is resolved and outdated on the current source.Integration boundary
Keep Draft/unmerged while #118 owns exact
v0.6.0publication from unchanged protected main. This next-release supply-chain repair is not represented as protected-main behavior or shipped release evidence.