fix(reliability): preflight guarded-restore digest capability - #277
Draft
seonghobae wants to merge 3 commits into
Draft
fix(reliability): preflight guarded-restore digest capability#277seonghobae wants to merge 3 commits into
seonghobae wants to merge 3 commits into
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
seonghobae
changed the base branch from
fix/digest-provider-preflight-221
to
main
August 12, 2026 11:32
seonghobae
changed the base branch from
main
to
fix/digest-provider-preflight-221
August 13, 2026 02:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #276.
Exact stacked boundary
This Draft is stacked on exact predecessor PR #222 head
2228267cc7b4f990b6a58556a74a26dda2685df8, branchfix/digest-provider-preflight-221. The stack is exact: current heada82c90598ac527ed71e9c32184783f78d1441c63is 3 commits ahead / 0 behind that predecessor and its merge base is the predecessor head. Protectedmainremains the separate frozen0.6.0candidatee8109ec2a17de8bd6594487aa12c8c8a93cb2c03owned by #118.Test-first proof
The dedicated real-editor regression landed first on
6bbd5eb3d040c45e4e2636ea687ff26df6c3845e, then the byte-path companion on042e8d800b567d50888904b0cb8772ba41ed0833.Exact checkout CI
31592476116on042e8d800b567d50888904b0cb8772ba41ed0833reached normal setup, immutable install, typecheck, browser evidence, and every Office lane. The JS coverage job then produced the intended product RED: all three new assertions failed while 824 unrelated tests passed. Invalid providers serialized the current document (toJSON()observed 3 calls on both object and byte paths), and an accessor-backed digest capability was read twice rather than once.Narrow repair
Current production commit
a82c90598ac527ed71e9c32184783f78d1441c63resolves the digest provider exactly once before current-document serialization, preserves the callable receiver, and reuses the captured resolved capability for both the current and resulting revision digests.Malformed-tag validation and destroyed-editor conflict precedence remain ahead of provider resolution. Moved-document conflicts, mismatch-without-source-inspection, object/byte source validation, schema and transaction-policy enforcement, atomic application, exact revision/envelope pairing, payload-redacted errors, and
emitUpdate=falsebehavior remain unchanged.Exact-head validation
At exact head
a82c90598ac527ed71e9c32184783f78d1441c63:31592741603: success;31592741637: success;31592741616: success;src/documentEnvelopeIfMatch.tsplussrc/documentEnvelopeIfMatchDigestPreflight.test.ts;Integration dependency
Keep Draft/unmerged while #222 remains the predecessor and #118 owns protected registry acceptance. Any predecessor-base or source-head movement invalidates ancestry and hosted evidence; no predecessor check transfers automatically.