Skip to content

fix(privacy): redact invalid XLSX worksheet names - #237

Closed
seonghobae wants to merge 4 commits into
mainfrom
fix/xlsx-name-error-redaction-193
Closed

fix(privacy): redact invalid XLSX worksheet names#237
seonghobae wants to merge 4 commits into
mainfrom
fix/xlsx-name-error-redaction-193

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Closed after splitting the overlapping Office lane into its authoritative writers.

Fresh repository refetch showed pre-existing Draft #192 already owns issue #193's office/src/inkspan_office/renderer.py worksheet-name redaction together with the DOCX image boundary, with exact-head GREEN proof at f7634a6b0dfb4e7d83d326d37f949fd6422692a1 (CI 31476748415, Security 31476748446, SAST 31476748355). Keeping this PR's renderer edit open would violate the single-writer lease.

This PR also exposed a distinct compatibility-name leak in office/src/inkspan_office/safe_renderer.py ('name/History). That non-overlapping gap is now tracked as issue #245 and test-first Draft #246, whose production lane is intentionally restricted to safe_renderer.py plus its dedicated regression.

No checks/reviews from this closed mixed lane are transferred to #192 or #246.

@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: ccfb75f2-68d6-43d9-8dd9-0582345903b0

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@seonghobae seonghobae closed this Aug 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant