fix(privacy): redact invalid XLSX worksheet names - #237
Closed
seonghobae wants to merge 4 commits into
Closed
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closed after splitting the overlapping Office lane into its authoritative writers.
Fresh repository refetch showed pre-existing Draft #192 already owns issue #193's
office/src/inkspan_office/renderer.pyworksheet-name redaction together with the DOCX image boundary, with exact-head GREEN proof atf7634a6b0dfb4e7d83d326d37f949fd6422692a1(CI31476748415, Security31476748446, SAST31476748355). Keeping this PR's renderer edit open would violate the single-writer lease.This PR also exposed a distinct compatibility-name leak in
office/src/inkspan_office/safe_renderer.py('name/History). That non-overlapping gap is now tracked as issue #245 and test-first Draft #246, whose production lane is intentionally restricted tosafe_renderer.pyplus its dedicated regression.No checks/reviews from this closed mixed lane are transferred to #192 or #246.