π¨ Palette: μκ°μ Hover νΌλλ°± 볡μ - #791
seonghobae wants to merge 5 commits into
Conversation
π‘ What: μμ λλ ν 리(..)μ νμ νμΌ/λλ ν 리 λ§ν¬μ λ§μ°μ€λ₯Ό μ¬λ¦΄ λ ν μ€νΈ λ°μ€μ΄ νμλμ§ μλ λ¬Έμ λ₯Ό μμ νμ΅λλ€. css ꡬ쑰 μ νμμΈ `span:last-child` λμ `.entry-label` μ΄λΌλ μλ§¨ν± ν΄λμ€λ₯Ό μΆκ°νμ¬ μ μ©λλλ‘ λ³κ²½νμ΅λλ€. π― Why: `.visually-hidden` ν΄λμ€λ₯Ό κ°μ§λ μμκ° `li` λ΄ λ§μ§λ§ `span`μ΄ λλ©΄μ μκ°μ hover μ€νμΌμ΄ μ¨κ²¨μ§ μμμ μ μ©λμ΄λ²λ¦¬λ λ¬Έμ λ₯Ό ν΄κ²°νμ΅λλ€. πΈ Before/After: λ§μ°μ€ hover μ λ§ν¬ ν μ€νΈμ λ€μ λ°μ€μ΄ κ·Έμ΄μ Έ μνΈμμ© κ°λ₯ν μμμμ μκ°μ μΌλ‘ λͺ νν μ λ¬ν©λλ€. βΏ Accessibility: μ€ν¬λ¦° 리λμ© ν μ€νΈ(`.visually-hidden`)λ₯Ό μ μ§νλ©΄μλ μκ° μ₯μ κ° μλ μΌλ° μ¬μ©μλ€μ μ¬μ©μ±(μκ°μ νΈλ² νΌλλ°±)μ 볡μνμ΅λλ€.
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
π‘ What: μμ λλ ν 리(..)μ νμ νμΌ/λλ ν 리 λ§ν¬μ λ§μ°μ€λ₯Ό μ¬λ¦΄ λ ν μ€νΈ λ°μ€μ΄ νμλμ§ μλ λ¬Έμ λ₯Ό μμ νμ΅λλ€. css ꡬ쑰 μ νμμΈ `span:last-child` λμ `.entry-label` μ΄λΌλ μλ§¨ν± ν΄λμ€λ₯Ό μΆκ°νμ¬ μ μ©λλλ‘ λ³κ²½νμ΅λλ€. π― Why: `.visually-hidden` ν΄λμ€λ₯Ό κ°μ§λ μμκ° `li` λ΄ λ§μ§λ§ `span`μ΄ λλ©΄μ μκ°μ hover μ€νμΌμ΄ μ¨κ²¨μ§ μμμ μ μ©λμ΄λ²λ¦¬λ λ¬Έμ λ₯Ό ν΄κ²°νμ΅λλ€. πΈ Before/After: λ§μ°μ€ hover μ λ§ν¬ ν μ€νΈμ λ€μ λ°μ€μ΄ κ·Έμ΄μ Έ μνΈμμ© κ°λ₯ν μμμμ μκ°μ μΌλ‘ λͺ νν μ λ¬ν©λλ€. βΏ Accessibility: μ€ν¬λ¦° 리λμ© ν μ€νΈ(`.visually-hidden`)λ₯Ό μ μ§νλ©΄μλ μκ° μ₯μ κ° μλ μΌλ° μ¬μ©μλ€μ μ¬μ©μ±(μκ°μ νΈλ² νΌλλ°±)μ 볡μνμ΅λλ€.
π‘ What: μμ λλ ν 리(..)μ νμ νμΌ/λλ ν 리 λ§ν¬μ λ§μ°μ€λ₯Ό μ¬λ¦΄ λ ν μ€νΈ λ°μ€μ΄ νμλμ§ μλ λ¬Έμ λ₯Ό μμ νμ΅λλ€. css ꡬ쑰 μ νμμΈ `span:last-child` λμ `.entry-label` μ΄λΌλ μλ§¨ν± ν΄λμ€λ₯Ό μΆκ°νμ¬ μ μ©λλλ‘ λ³κ²½νμ΅λλ€. π― Why: `.visually-hidden` ν΄λμ€λ₯Ό κ°μ§λ μμκ° `li` λ΄ λ§μ§λ§ `span`μ΄ λλ©΄μ μκ°μ hover μ€νμΌμ΄ μ¨κ²¨μ§ μμμ μ μ©λμ΄λ²λ¦¬λ λ¬Έμ λ₯Ό ν΄κ²°νμ΅λλ€. πΈ Before/After: λ§μ°μ€ hover μ λ§ν¬ ν μ€νΈμ λ€μ λ°μ€μ΄ κ·Έμ΄μ Έ μνΈμμ© κ°λ₯ν μμμμ μκ°μ μΌλ‘ λͺ νν μ λ¬ν©λλ€. βΏ Accessibility: μ€ν¬λ¦° 리λμ© ν μ€νΈ(`.visually-hidden`)λ₯Ό μ μ§νλ©΄μλ μκ° μ₯μ κ° μλ μΌλ° μ¬μ©μλ€μ μ¬μ©μ±(μκ°μ νΈλ² νΌλλ°±)μ 볡μνμ΅λλ€.
Design assurance disposition β 2026-09-26Exact head: Draft/Proposed single-writer gate: this overlaps #784/#789 on the same generated hover/focus selector and visible-name surface. Preserve the delta, but reconcile ordinary-forward into one canonical writer with generated-HTML contract and pointer/keyboard screenshots before protected-main integration. No simple duplicate close. No force push, destructive rebase, blind rerun, or valid-delta retirement. |
μλ΄ κ°μ¬ν©λλ€. λ§μνμ λλ‘ λ³κ²½ μ¬ν(delta)μ μ μ§νλ©° κ°μ νΈμλ λ¦¬λ² μ΄μ€ λ±μ μννμ§ μκ² μ΅λλ€. λ³ν© μ μ μ μμ±μ μ‘°μ λ° νμΈ κ³Όμ μ΄ μ μ§νλκΈ°λ₯Ό λ°λλλ€. |
π‘ What: μμ λλ ν 리(..)μ νμ νμΌ/λλ ν 리 λ§ν¬μ λ§μ°μ€λ₯Ό μ¬λ¦΄ λ ν μ€νΈ λ°μ€μ΄ νμλμ§ μλ λ¬Έμ λ₯Ό μμ νμ΅λλ€. css ꡬ쑰 μ νμμΈ `span:last-child` λμ `.entry-label` μ΄λΌλ μλ§¨ν± ν΄λμ€λ₯Ό μΆκ°νμ¬ μ μ©λλλ‘ λ³κ²½νμ΅λλ€. π― Why: `.visually-hidden` ν΄λμ€λ₯Ό κ°μ§λ μμκ° `li` λ΄ λ§μ§λ§ `span`μ΄ λλ©΄μ μκ°μ hover μ€νμΌμ΄ μ¨κ²¨μ§ μμμ μ μ©λμ΄λ²λ¦¬λ λ¬Έμ λ₯Ό ν΄κ²°νμ΅λλ€. πΈ Before/After: λ§μ°μ€ hover μ λ§ν¬ ν μ€νΈμ λ€μ λ°μ€μ΄ κ·Έμ΄μ Έ μνΈμμ© κ°λ₯ν μμμμ μκ°μ μΌλ‘ λͺ νν μ λ¬ν©λλ€. βΏ Accessibility: μ€ν¬λ¦° 리λμ© ν μ€νΈ(`.visually-hidden`)λ₯Ό μ μ§νλ©΄μλ μκ° μ₯μ κ° μλ μΌλ° μ¬μ©μλ€μ μ¬μ©μ±(μκ°μ νΈλ² νΌλλ°±)μ 볡μνμ΅λλ€.
π‘ What: μμ λλ ν 리(..)μ νμ νμΌ/λλ ν 리 λ§ν¬μ λ§μ°μ€λ₯Ό μ¬λ¦΄ λ ν μ€νΈ λ°μ€μ΄ νμλμ§ μλ λ¬Έμ λ₯Ό μμ νμ΅λλ€. css ꡬ쑰 μ νμμΈ `span:last-child` λμ `.entry-label` μ΄λΌλ μλ§¨ν± ν΄λμ€λ₯Ό μΆκ°νμ¬ μ μ©λλλ‘ λ³κ²½νμ΅λλ€. π― Why: `.visually-hidden` ν΄λμ€λ₯Ό κ°μ§λ μμκ° `li` λ΄ λ§μ§λ§ `span`μ΄ λλ©΄μ μκ°μ hover μ€νμΌμ΄ μ¨κ²¨μ§ μμμ μ μ©λμ΄λ²λ¦¬λ λ¬Έμ λ₯Ό ν΄κ²°νμ΅λλ€. πΈ Before/After: λ§μ°μ€ hover μ λ§ν¬ ν μ€νΈμ λ€μ λ°μ€μ΄ κ·Έμ΄μ Έ μνΈμμ© κ°λ₯ν μμμμ μκ°μ μΌλ‘ λͺ νν μ λ¬ν©λλ€. βΏ Accessibility: μ€ν¬λ¦° 리λμ© ν μ€νΈ(`.visually-hidden`)λ₯Ό μ μ§νλ©΄μλ μκ° μ₯μ κ° μλ μΌλ° μ¬μ©μλ€μ μ¬μ©μ±(μκ°μ νΈλ² νΌλλ°±)μ 볡μνμ΅λλ€.
π‘ What: μμ λλ ν 리(..)μ νμ νμΌ/λλ ν 리 λ§ν¬μ λ§μ°μ€λ₯Ό μ¬λ¦΄ λ ν μ€νΈ λ°μ€μ΄ νμλμ§ μλ λ¬Έμ λ₯Ό μμ νμ΅λλ€. css ꡬ쑰 μ νμμΈ
span:last-childλμ.entry-labelμ΄λΌλ μλ§¨ν± ν΄λμ€λ₯Ό μΆκ°νμ¬ μ μ©λλλ‘ λ³κ²½νμ΅λλ€.π― Why:
.visually-hiddenν΄λμ€λ₯Ό κ°μ§λ μμκ°liλ΄ λ§μ§λ§spanμ΄ λλ©΄μ μκ°μ hover μ€νμΌμ΄ μ¨κ²¨μ§ μμμ μ μ©λμ΄λ²λ¦¬λ λ¬Έμ λ₯Ό ν΄κ²°νμ΅λλ€.πΈ Before/After: λ§μ°μ€ hover μ λ§ν¬ ν μ€νΈμ λ€μ λ°μ€μ΄ κ·Έμ΄μ Έ μνΈμμ© κ°λ₯ν μμμμ μκ°μ μΌλ‘ λͺ νν μ λ¬ν©λλ€.
βΏ Accessibility: μ€ν¬λ¦° 리λμ© ν μ€νΈ(
.visually-hidden)λ₯Ό μ μ§νλ©΄μλ μκ° μ₯μ κ° μλ μΌλ° μ¬μ©μλ€μ μ¬μ©μ±(μκ°μ νΈλ² νΌλλ°±)μ 볡μνμ΅λλ€.PR created automatically by Jules for task 15578988038757713927 started by @seonghobae