-
Notifications
You must be signed in to change notification settings - Fork 0
π¨ Palette: hover μ λ μ΄λΈ ν μ€νΈμλ§ λ°μ€ μ μ© #779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
98dbbae
685d76a
680ed07
3b75a59
ccd2fe5
222eaee
980bdc4
a87f4cd
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -56,7 +56,7 @@ a:hover, a:focus-visible { | |
| outline: 2px solid #0969da; | ||
| outline-offset: -2px; | ||
| } | ||
| a:hover span:last-child, a:focus-visible span:last-child { | ||
| a:hover .entry-label, a:focus-visible .entry-label { | ||
| text-decoration: underline; | ||
| } | ||
| @media (prefers-reduced-motion: reduce) { | ||
|
|
@@ -429,7 +429,7 @@ fun process_dir(curr_dir: File, excludeSet: Set<String>? = null, dirFiles: Array | |
| <h1>${directoryName.escapeHtml()}</h1> | ||
| <nav aria-label="λλ ν 리 λͺ©λ‘"> | ||
| <ul role="list"> | ||
| <li><a class="dir-link" href="./.." title="μμ λλ ν λ¦¬λ‘ μ΄λ"><span class="icon" aria-hidden="true">↰</span> <span aria-hidden="true">..</span> <span class="visually-hidden">μμ λλ ν λ¦¬λ‘ μ΄λ</span></a></li> | ||
| <li><a class="dir-link" href="./.." title="μμ λλ ν λ¦¬λ‘ μ΄λ"><span class="icon" aria-hidden="true">↰</span> <span class="entry-label" aria-hidden="true">..</span> <span class="visually-hidden">μμ λλ ν λ¦¬λ‘ μ΄λ</span></a></li> | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. π― Functional Correctness | π Major | β‘ Quick win μμ λ§ν¬ ν μ€νΈμ κΈ°λ λ§ν¬μ μ κ°±μ νμΈμ.
κΈ°λ λ¬Έμμ΄ μμ μμ- val parentIndex = generatedHtml.indexOf("<span aria-hidden=\"true\">..</span>")
+ val parentIndex = generatedHtml.indexOf("<span class=\"entry-label\" aria-hidden=\"true\">..</span>")π€ Prompt for AI Agentsπ― Functional Correctness | π‘ Minor | β‘ Quick win μμ± λ§ν¬μ Line 432μ Line 463μ μ½λ© μ§μΉ¨μ λ°λΌ βadd Also applies to: 463-463 π€ Prompt for AI AgentsSource: Coding guidelines |
||
| """ | ||
|
|
||
| val index_middle = fun():String{ | ||
|
|
@@ -460,7 +460,7 @@ fun process_dir(curr_dir: File, excludeSet: Set<String>? = null, dirFiles: Array | |
| val ariaLabel = "${fileName} ${if (isLinkedDirectory) { "λλ ν 리" } else { "νμΌ" }}".escapeHtml() | ||
| val typeLabel = if (isLinkedDirectory) { "λλ ν 리" } else { "νμΌ" } | ||
| val icon = if (isLinkedDirectory) { "📁" } else { "📄" } | ||
| l.append(""" <li><a class="dir-link" href="${encodedHref}" title="${ariaLabel}"><span class="icon" aria-hidden="true">${icon}</span> <span>${fileName.escapeHtml()}</span> <span class="visually-hidden">${typeLabel}</span></a></li>""") | ||
| l.append(""" <li><a class="dir-link" href="${encodedHref}" title="${ariaLabel}"><span class="icon" aria-hidden="true">${icon}</span> <span class="entry-label">${fileName.escapeHtml()}</span> <span class="visually-hidden">${typeLabel}</span></a></li>""") | ||
| l.append('\n') | ||
| } | ||
| } | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
π Maintainability & Code Quality | π‘ Minor | β‘ Quick win
μ νλͺ©μ λ μ§λ₯Ό μμ νμΈμ.
μ΄ λ³κ²½μμ μΆκ°ν νλͺ©μ μ λͺ©μ
2024-09-24λ‘ νκΈ°λμ΄ μμ΅λλ€. μ§μ νλͺ©μ2026-08-17μ΄λ©° νμ¬ λ μ§λ2026-09-24μ λλ€. μ€μ μμ±μΌμ λ§κ² λ μ§λ₯Ό μμ ν΄ λ¬Έμμ μκ° μμλ₯Ό μ μ§νμΈμ.π€ Prompt for AI Agents