🛡️ Sentinel: [security improvement] Remove environment variable fallbacks

[seonghobae]

🚨 Severity

CRITICAL

💡 Vulnerability

환경변수에 비밀키 의존성이 있을 때 폴백(:) 구문으로 인해 환경 변수 설정 누락 시 빈 문자열이 암묵적으로 주입되어 보안 서명이 취약해지는 문제점이 존재했습니다.

🎯 Impact

인증 토큰, 테넌트 서명 등에서 사용하는 HMAC 시크릿이 빈 문자열로 서명될 수 있어, 잠재적으로 악의적인 공격자가 쉽게 서명을 위조하고 인가를 우회할 수 있습니다.

🔧 Fix

application-buyer-demo.yml 및 ArtifactLinkService, ProductionAuthReadinessConfig, TenantAccessService의 @Value 어노테이션에서 변수 폴백(:) 구문을 제거하여 명시적인 값이 제공되도록 강제했습니다. 이를 통해 Spring Boot의 configtree 마운팅 메커니즘을 적용하게 됩니다.

✅ Verification

1. mvn clean test 를 실행하여 모든 테스트를 성공적으로 통과했습니다.
2. 추가적인 검증 스크립트 작성 및 뷰어 실행 환경 정상 작동 여부 검토를 수행했습니다.

---

PR created automatically by Jules for task 5876649705136805700 started by @seonghobae

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

---

For security, I will only act on instructions from the user who triggered this task.

[coderabbitai]

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 57 minutes

Limit details: You’ve used all 1 included review currently available under your plan.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: dc300608-face-4144-b1d4-8a054f0b81d2

📥 Commits

Reviewing files that changed from the base of the PR and between eb0a32e and 60b00df.

📒 Files selected for processing (8)

• .jules/sentinel.md
• src/main/java/com/clearfolio/viewer/artifact/ArtifactLinkService.java
• src/main/java/com/clearfolio/viewer/auth/TenantAccessService.java
• src/main/java/com/clearfolio/viewer/config/ProductionAuthReadinessConfig.java
• src/main/java/com/clearfolio/viewer/controller/ArtifactController.java
• src/main/java/com/clearfolio/viewer/controller/ConversionController.java
• src/main/resources/application-buyer-demo.yml
• src/test/java/com/clearfolio/viewer/config/ProductionAuthReadinessConfigTest.java

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}