Skip to content

fix(viewer): remove unrelated branding on current main - #447

Closed
seonghobae wants to merge 2 commits into
mainfrom
fix/clearfolio-branding-current-main-20260814
Closed

fix(viewer): remove unrelated branding on current main#447
seonghobae wants to merge 2 commits into
mainfrom
fix/clearfolio-branding-current-main-20260814

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 14, 2026

Copy link
Copy Markdown
Collaborator

Superseded by #459

This stale-base branch is closed without merge. PR #459 reconstructs the same reviewed two-file product-branding result directly on current protected main eb0a32e87e7470469c8fa0f8c67d9583654bef57 as exactly one commit with zero behind commits. The modified protected-main input blob was byte-identical to this branch's construction input, and both reconstructed output blobs are byte-identical to this reviewed result.

No checks, reviews, or approvals from #447 transfer to #459.

Historical objective

Remove unrelated company ownership claims from Clearfolio's buyer-visible HTML shells.

@coderabbitai

coderabbitai Bot commented Aug 14, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 20 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: d5281508-24d6-4937-82d4-ffc35ca41196

📥 Commits

Reviewing files that changed from the base of the PR and between 961f44a and 874e471.

📒 Files selected for processing (2)
  • src/main/java/com/clearfolio/viewer/controller/ViewerUiController.java
  • src/test/java/com/clearfolio/viewer/controller/ViewerUiBrandingContractTest.java

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@seonghobae
seonghobae marked this pull request as ready for review August 14, 2026 09:31
@seonghobae
seonghobae enabled auto-merge (squash) August 14, 2026 09:31

Copy link
Copy Markdown
Collaborator Author

Exact-current-head read-only review request for 874e471e4179116cbf3cc58cc972a87b11d5ec80 on protected main 961f44a19c4ced87f8062b3ab9842a9a08d05235. CI, Security Scan, SAST Semgrep, and fuzz are terminal-success; the two-file branding-truth delta is mergeable with zero unresolved threads. Verify that production shells identify Clearfolio and Apache-2.0 without an unrelated company ownership claim, while preserving current viewer and artifact-token behavior. Do not mutate the branch or bypass independent approval.

@opencode-agent review
@cwl-noema-review review
@strix review
@coderabbitai review

@coderabbitai

coderabbitai Bot commented Aug 14, 2026

Copy link
Copy Markdown

Rate Limit Exceeded

@seonghobae have exceeded the limit for the number of chat messages per hour. Please wait 2 minutes and 19 seconds before sending another message.

Copy link
Copy Markdown
Collaborator Author

@opencode-agent review
@coderabbitai review
@cwl-noema-review review
@strix review

Review exact head 874e471e4179116cbf3cc58cc972a87b11d5ec80 only. Current exact-head CI, Security Scan, SAST Semgrep, and fuzz are terminal-success; unresolved review threads are zero. Review read-only and preserve independent reviewer identity. Do not mutate the branch, synthesize author approval, weaken protection, or merge.

@coderabbitai

coderabbitai Bot commented Aug 15, 2026

Copy link
Copy Markdown

Tip

For best results, initiate chat on the files or code changes.

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

base='961f44a19c4ced87f8062b3ab9842a9a08d05235'
head='874e471e4179116cbf3cc58cc972a87b11d5ec80'

printf '%s\n' '== Exact commit and ancestry =='
git rev-parse HEAD
git show -s --format='commit=%H%nparents=%P%nsubject=%s' "$head"
git merge-base --is-ancestor "$base" "$head"
printf 'base_is_ancestor=yes\n'

printf '%s\n' '== Changed paths =='
git diff --name-status "$base" "$head"
printf '%s\n' '== Full review diff =='
git diff --find-renames --find-copies --unified=80 "$base" "$head"

printf '%s\n' '== Candidate file locations =='
fd -a 'ViewerUiController\.java|ViewerUiController.*Test.*\.java|ViewerUiController.*IT.*\.java' .

printf '%s\n' '== Source structure =='
src=$(fd -a -t f '^ViewerUiController\.java$' . | head -n1)
test_files=$(fd -a -t f 'ViewerUiController.*(Test|IT).*\.java$' . || true)
if [ -n "$src" ]; then
  ast-grep outline "$src" --items all --view expanded || true
  printf '%s\n' '== Source: ownership, viewer, and artifact-token context =='
  rg -n -i -C 12 'clearfolio|hyosung|apache|artifact|token|viewer|document' "$src"
fi
for test in $test_files; do
  printf '%s\n' "== Test outline: $test =="
  ast-grep outline "$test" --items all --view expanded || true
  rg -n -i -C 10 'clearfolio|hyosung|apache|ownership|branding|viewer|document' "$test"
done

Length of output: 45119


@seonghobae

I reviewed exact head 874e471e4179116cbf3cc58cc972a87b11d5ec80 against base 961f44a19c4ced87f8062b3ab9842a9a08d05235.

The diff is limited to the two stated paths. The production shells now identify Clearfolio Viewer · Apache-2.0. The diff does not alter document ID handling, viewer state, PDF.js paths, viewer scripts, or artifact-link behavior.

One finding remains:

  • P2 — Test the Apache-2.0 part of the branding contract. ViewerUiBrandingContractTest.java checks for Clearfolio Viewer and rejects HYOSUNG, but it does not check for Apache-2.0. A future footer change that removes the distribution identifier would pass both new tests while violating the stated shell contract. Assert Apache-2.0 for both / and /viewer/{docId} responses.

I did not modify the branch, approve the pull request, change protection, or merge.

You are interacting with an AI system.

Copy link
Copy Markdown
Collaborator Author

Exact-current-head independent review request for 874e471e4179116cbf3cc58cc972a87b11d5ec80.

The two-file branding-truth slice is mergeable; CI, Security Scan, SAST Semgrep, and fuzz are terminal-success; unresolved inline findings are zero. Both product shells identify Clearfolio and the Apache-2.0 distribution without asserting unrelated ownership. Protected main has advanced since construction, so any base update must regenerate all exact-head evidence.

@opencode-agent review
@coderabbitai review
@cwl-noema-review review
@strix review

Review this exact head read-only. Do not mutate the branch, synthesize author approval, weaken protection, or merge.

@coderabbitai

coderabbitai Bot commented Aug 15, 2026

Copy link
Copy Markdown

Rate Limit Exceeded

@seonghobae have exceeded the limit for the number of chat messages per hour. Please wait 7 minutes and 21 seconds before sending another message.

Copy link
Copy Markdown
Collaborator Author

Exact-head review/update request for 874e471e4179116cbf3cc58cc972a87b11d5ec80.

The bounded buyer-visible branding correction has terminal-success CI, Security Scan, SAST Semgrep, and fuzz, is mergeable, and has zero unresolved threads. Its construction base predates current protected main; update to the current base and regenerate every base-sensitive gate before approval or merge if protection requires it. Preserve the two-file branding-only scope.

@coderabbitai review
@opencode-agent review
@cwl-noema-review review
@strix review

@coderabbitai

coderabbitai Bot commented Aug 15, 2026

Copy link
Copy Markdown

Rate Limit Exceeded

@seonghobae have exceeded the limit for the number of chat messages per hour. Please wait 9 minutes and 25 seconds before sending another message.

@seonghobae seonghobae closed this Aug 15, 2026
auto-merge was automatically disabled August 15, 2026 13:05

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant