fix(security): reconcile tenant submission authority on current main - #438
fix(security): reconcile tenant submission authority on current main#438seonghobae wants to merge 6 commits into
Conversation
|
Important Review available on request
Reviews should be triggered manually for repositories with fewer than 10 stars. Select Trigger review above or comment ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Exact-current-head review request for @opencode-agent review |
|
|
|
@opencode-agent review Review exact head Review read-only; preserve independent reviewer identity. Do not mutate the branch, synthesize author approval, weaken protection, or merge. |
Rate Limit Exceeded
|
Objective
Reconcile stale PR #346's fail-closed tenant-aware submission boundary directly on protected
main, without importing stale ancestry or changing the explicit legacy/demo submission overloads.Exact current-head evidence
961f44a19c4ced87f8062b3ab9842a9a08d05235;763bc9ac3204180710f2333c6a222810eb808920;DefaultDocumentConversionService.submit(...)plus two focused regressions only;Security contract
The production tenant-aware submission overload rejects an absent
TenantContextbefore validation, hashing, repository access, artifact storage, or worker dispatch. It no longer invents buyer-demo tenant or subject authority at an authenticated boundary. The explicitly tenant-less overload remains the separate legacy/demo compatibility path and continues to construct its documented demo context before delegating.Scope boundary
Tenant-aware submission authority only. This does not implement production OIDC/JWT, change tenant/permission header semantics, add durable job persistence, alter upload validation or deduplication, or remove the explicit legacy/demo overload. Issue #314 and the credential-registry stack own those separate authentication concerns.
Merge gate
Keep this exact head unchanged. Auto-merge may act only after all live required checks remain successful, zero valid unresolved findings remain, and a qualifying independent non-author approval is attached to this exact head. If live protection requires an updated base, rebuild or update against protected
mainand regenerate every base-sensitive check and review. No predecessor evidence transfers.