fix(reliability): reconcile artifact ledger on current main - #435
fix(reliability): reconcile artifact ledger on current main#435seonghobae wants to merge 11 commits into
Conversation
|
Warning Review limit reached
Next review available in: 36 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Exact-current-head review request for @opencode-agent review |
|
|
|
@opencode-agent review Review exact head Review read-only; preserve independent reviewer identity. Do not mutate the branch, synthesize author approval, weaken protection, or merge. |
🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
expected_head='777cd3c722fe6c3ad27bfb45d981aea86444606e'
base='961f44a19c4ced87f8062b3ab9842a9a08d05235'
printf '%s\n' '== checked-out commit =='
git rev-parse HEAD
printf '%s\n' '== requested commits available =='
git cat-file -t "$expected_head"
git cat-file -t "$base"
printf '%s\n' '== changed paths =='
git diff --name-status "$base" "$expected_head"
printf '%s\n' '== diff statistics =='
git diff --stat "$base" "$expected_head"
printf '%s\n' '== ArtifactLinkLedger locations =='
fd -a 'ArtifactLinkLedger\.java$' .
printf '%s\n' '== Java outlines for changed files =='
while IFS= read -r path; do
ast-grep outline "$path" --items all --type class,interface,method,constructor --view expanded || true
done < <(git diff --name-only "$base" "$expected_head" -- '*.java')
printf '%s\n' '== exact source diff =='
git diff --find-renames --find-copies --unified=80 "$base" "$expected_head" -- '*.java'Length of output: 2448 🏁 Script executed: #!/bin/bash
set -euo pipefail
base='961f44a19c4ced87f8062b3ab9842a9a08d05235'
head='777cd3c722fe6c3ad27bfb45d981aea86444606e'
ledger='src/main/java/com/clearfolio/viewer/artifact/ArtifactLinkLedger.java'
service_test='src/test/java/com/clearfolio/viewer/artifact/ArtifactLinkServiceTest.java'
rebinding_test='src/test/java/com/clearfolio/viewer/artifact/ArtifactLinkLedgerAuthorityRebindingTest.java'
durability_test='src/test/java/com/clearfolio/viewer/artifact/ArtifactLinkLedgerDurabilityTest.java'
fail_closed_test='src/test/java/com/clearfolio/viewer/artifact/ArtifactLinkLedgerFailClosedTest.java'
printf '%s\n' '== complete Java diff =='
git diff --find-renames --find-copies --unified=100 "$base" "$head" -- '*.java'
printf '%s\n' '== production outlines =='
ast-grep outline "$ledger" --items all --view expanded
service_path="$(fd -a '^ArtifactLinkService\.java$' src/main/java | head -n 1)"
printf '%s\n' "== service path: ${service_path:-not-found} =="
if [ -n "${service_path:-}" ]; then
ast-grep outline "$service_path" --items all --view expanded
fi
printf '%s\n' '== complete changed regression tests =='
for path in "$rebinding_test" "$durability_test" "$fail_closed_test" "$service_test"; do
printf '\n== %s ==\n' "$path"
cat -n "$path"
done
printf '%s\n' '== current ledger source =='
cat -n "$ledger"
if [ -n "${service_path:-}" ]; then
printf '%s\n' '== service calls to ledger and publication-related methods =='
rg -n -C 8 --glob '*.java' \
'(ArtifactLinkLedger|\.issue\(|\.revoke\(|\.read\(|append|publish|audit)' \
"$service_path"
fiLength of output: 106253 🏁 Script executed: #!/bin/bash
set -euo pipefail
service='src/main/java/com/clearfolio/viewer/artifact/ArtifactLinkService.java'
ledger='src/main/java/com/clearfolio/viewer/artifact/ArtifactLinkLedger.java'
printf '%s\n' '== ArtifactLinkService issue, revoke, and read methods =='
sed -n '120,315p' "$service" | cat -n
printf '%s\n' '== all production calls to ArtifactLinkLedger state-changing methods =='
rg -n -C 6 --glob '*.java' \
'\bartifactLinkLedger\.(recordIssued|revoke|recordRead)\s*\(' \
src/main/java
printf '%s\n' '== all ledger construction and state-changing calls =='
rg -n -C 4 --glob '*.java' \
'\bnew\s+ArtifactLinkLedger\s*\(|\.(recordIssued|revoke|recordRead)\s*\(' \
src/main/java src/test/java
printf '%s\n' '== replay, malformed, truncation, and invalid-ledger test coverage =='
rg -n -i -C 5 --glob '*ArtifactLink*Test.java' \
'(replay|malformed|truncat|invalid line|invalid.*ledger|ledger.*invalid)' \
src/test/java
printf '%s\n' '== base-to-head focused semantic diff for service test adjustment =='
git diff --unified=30 \
961f44a19c4ced87f8062b3ab9842a9a08d05235 \
777cd3c722fe6c3ad27bfb45d981aea86444606e \
-- src/test/java/com/clearfolio/viewer/artifact/ArtifactLinkServiceTest.java
printf '%s\n' '== current repository status =='
git status --shortLength of output: 66390
I found no blocking issues in the requested integrity scope.
I did not modify the branch, approve the pull request, merge, or change protection settings.
|
|
Exact-current-head independent review request for The five-file artifact-ledger integrity parent is mergeable; CI, Security Scan, SAST Semgrep, and fuzz are terminal-success; unresolved inline findings are zero. This parent must reach protected @opencode-agent review Review this exact head read-only. Do not mutate the branch, synthesize author approval, weaken protection, or merge. |
Rate Limit Exceeded
|
|
Exact-head review/update request for The bounded artifact-ledger integrity parent has terminal-success CI, Security Scan, SAST Semgrep, and fuzz, is mergeable, and has zero unresolved inline threads. Its construction base @coderabbitai review |
Rate Limit Exceeded
|
1 participant
Superseded by #457
This stale-base branch is closed without merge. PR #457 reconstructs the same reviewed five-file artifact-ledger integrity result directly on current protected
maineb0a32e87e7470469c8fa0f8c67d9583654bef57as exactly one commit with zero behind commits. The two modified protected-main input blobs were byte-identical to this branch's construction inputs, and all five reconstructed output blobs are byte-identical to this reviewed result.No checks, reviews, approvals, or child evidence from #435 transfer to #457. Ordered children #448 → #449 → #450 must be rebuilt after #457 reaches protected main.
Historical objective
Reconcile the bounded fail-closed artifact-link ledger integrity slice directly on the protected-main line without importing stale #357 ancestry.