fix(viewer): report only qualified renderer metadata on current main - #417
fix(viewer): report only qualified renderer metadata on current main#417seonghobae wants to merge 5 commits into
Conversation
|
Important Review available on request
Reviews should be triggered manually for repositories with fewer than 10 stars. Select Trigger review above or comment ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@opencode-agent review Please review the unchanged exact current head |
|
Exact-current-head read-only review request for @opencode-agent review |
🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
base="961f44a19c4ced87f8062b3ab9842a9a08d05235"
head="e2379d30e9abf4d71858bba9b630b121100eef86"
printf '%s\n' '== checked-out commit =='
git rev-parse HEAD
printf '%s\n' '== supplied commits =='
git show -s --format='%H%n%P%n%s' "$base" "$head"
printf '%s\n' '== changed files and stat =='
git diff --stat "$base" "$head"
git diff --name-status "$base" "$head"
printf '%s\n' '== complete supplied diff =='
git diff --find-renames --find-copies --no-ext-diff "$base" "$head"
printf '%s\n' '== changed-file outlines =='
git diff --name-only "$base" "$head" | while IFS= read -r path; do
printf '\n-- %s --\n' "$path"
ast-grep outline "$path" --items all --view expanded || true
done
printf '%s\n' '== renderer and provenance references =='
rg -n -C 4 --glob '!node_modules/**' --glob '!dist/**' \
'PDF_JS|renderer|Renderer|sourceExtension|source_extension|extension.*normaliz|normaliz.*extension' .
printf '%s\n' '== pull request identity, files, checks, and reviews =='
gh pr view 417 --repo ContextualWisdomLab/clearfolio \
--json number,url,headRefOid,baseRefOid,mergeable,reviewDecision,statusCheckRollup,reviews,files
printf '%s\n' '== review thread state =='
gh api graphql \
-F owner='ContextualWisdomLab' \
-F name='clearfolio' \
-F number=417 \
-f query='
query($owner: String!, $name: String!, $number: Int!) {
repository(owner: $owner, name: $name) {
pullRequest(number: $number) {
reviewThreads(first: 100) {
nodes {
isResolved
isOutdated
path
line
comments(first: 20) {
nodes { author { login } body }
}
}
}
}
}
}' \
--jq '.data.repository.pullRequest.reviewThreads.nodes[] |
select(.isResolved == false) |
{path, line, isOutdated, comments: [.comments.nodes[] | {author: .author.login, body}]}'Length of output: 98642
No findings.
The live checks for this exact head are successful. This includes Maven tests, merge compatibility, OSV, dependency review, Trivy, Semgrep, CodeQL, fuzz, and Strix. I also checked the repository security-gate requirement from the retrieved guidance. The required evidence gates remain active and successful. The pull request is mergeable. There are no unresolved review threads. GitHub still reports 🧠 Learnings used
|
|
@opencode-agent review Review exact head Review read-only; preserve independent reviewer identity. Do not mutate the branch, synthesize author approval, weaken protection, or merge. |
🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
repo="ContextualWisdomLab/clearfolio"
pr="417"
base="961f44a19c4ced87f8062b3ab9842a9a08d05235"
head="e2379d30e9abf4d71858bba9b630b121100eef86"
echo "== Local commit identity =="
git rev-parse HEAD
git show -s --format='base %H%nparents %P%nsubject %s' "$base"
git show -s --format='head %H%nparents %P%nsubject %s' "$head"
git merge-base --is-ancestor "$base" "$head" && echo "base-is-ancestor=true"
echo "== Exact diff file list and stat =="
git diff --name-status "$base" "$head"
git diff --stat "$base" "$head"
echo "== Exact complete diff =="
git diff --find-renames --find-copies --no-ext-diff "$base" "$head"
echo "== Changed file structure =="
git diff --name-only "$base" "$head" | while IFS= read -r f; do
echo "-- $f --"
ast-grep outline "$f" --items all --view expanded || true
done
echo "== Renderer and source-extension implementation references =="
rg -n -C 5 \
-g '!node_modules/**' -g '!dist/**' -g '!build/**' \
'rendererAdapter|RendererAdapter|PDF_JS|sourceExtension|source_extension|normalize.*[Ee]xtension|[Ee]xtension.*normalize' .
echo "== GitHub PR identity, checks, and reviews =="
gh pr view "$pr" --repo "$repo" \
--json url,headRefOid,baseRefOid,mergeable,reviewDecision,statusCheckRollup,reviews,files
echo "== Unresolved review threads =="
gh api graphql \
-F owner='ContextualWisdomLab' -F name='clearfolio' -F number="$pr" \
-f query='
query($owner: String!, $name: String!, $number: Int!) {
repository(owner: $owner, name: $name) {
pullRequest(number: $number) {
reviewThreads(first: 100) {
nodes {
isResolved
isOutdated
path
line
comments(first: 20) { nodes { author { login } body } }
}
}
}
}
}' \
--jq '.data.repository.pullRequest.reviewThreads.nodes[]
| select(.isResolved == false)
| {path, line, isOutdated, comments: [.comments.nodes[] | {author: .author.login, body}]}'Length of output: 81478
No findings.
The tests cover qualified and non-qualified source extensions. The controller tests retain The exact head is mergeable. The relevant CI, security, SAST, fuzz, CodeQL, and Strix checks completed successfully. The unresolved review-thread query returned no threads. GitHub still reports
|
|
Exact-current-head independent review request for The three-file viewer-metadata truth slice is mergeable; CI, Security Scan, SAST Semgrep, and fuzz are terminal-success; unresolved inline findings are zero. Every delivered bootstrap now reports the actually shipped @opencode-agent review Review this exact head read-only. Do not mutate the branch, synthesize author approval, weaken protection, or merge. |
Rate Limit Exceeded
|
1 participant
Objective
Make buyer-visible viewer bootstrap metadata report only renderer capability that Clearfolio actually delivers.
Exact current-head evidence
961f44a19c4ced87f8062b3ab9842a9a08d05235;00d3e4ed1cd4515b3b649cdd01592ca13a63911a;e2379d30e9abf4d71858bba9b630b121100eef86;Contract
Every currently delivered bootstrap advertises only the qualified
PDF_JSrenderer while preserving normalized source-extension metadata. Source filenames no longer fabricate DOCX, spreadsheet, slide, or text renderer adapters that are not shipped.Scope boundary
Buyer-visible metadata truth only. Office conversion, PDF.js runtime, authentication, async controls, lifecycle, OpenAPI, credentials, and canonical documentation are unchanged.
Merge gate
Keep this exact head unchanged. Auto-merge may act only after live checks remain successful, zero valid unresolved findings remain, and a qualifying independent non-author approval is attached to this exact head. Automated evidence and predecessor reviews do not transfer.