fix(overlap): restore isolated active-stem filter without local caps - #870
Closed
cursor[bot] wants to merge 27 commits into
Closed
fix(overlap): restore isolated active-stem filter without local caps#870cursor[bot] wants to merge 27 commits into
cursor[bot] wants to merge 27 commits into
Conversation
- 레지스터 중복 감지 이중 루프를 필터-루프로 개선하여 O(N^2) 성능 오버헤드 완화 - 대형 배열 오디오 처리에 의한 Unbounded Memory Consumption 완화 위해 사이즈 제한 적용 - trivy-fs 스캔에서 보고된 pdfjs-dist 취약점 패치 및 예외 처리
- 레지스터 중복 감지 이중 루프를 필터-루프로 개선하여 O(N^2) 성능 오버헤드 완화 - 대형 배열 오디오 처리에 의한 Unbounded Memory Consumption 완화 위해 최대 1억 샘플 사이즈 제한 적용 - 수많은 stem 인풋으로 인한 Denial of Service 방지를 위해 최대 stem 갯수 100개 제한 적용 - trivy-fs 스캔에서 보고된 pdfjs-dist 취약점 패치 및 예외 처리
- 레지스터 중복 감지 이중 루프를 필터-루프로 개선하여 O(N^2) 성능 오버헤드 완화 - 대형 배열 오디오 처리에 의한 Unbounded Memory Consumption 완화 위해 최대 1억 샘플 사이즈 제한 적용 - 수많은 stem 인풋으로 인한 Denial of Service 방지를 위해 최대 stem 갯수 100개 제한 적용 - trivy-fs 스캔에서 보고된 pdfjs-dist 취약점 패치 및 예외 처리
- 레지스터 중복 감지 이중 루프를 필터-루프로 개선하여 O(N^2) 성능 오버헤드 완화 - 대형 배열 오디오 처리에 의한 Unbounded Memory Consumption 완화 위해 최대 1억 샘플 사이즈 제한 적용 - 수많은 stem 인풋으로 인한 Denial of Service 방지를 위해 최대 stem 갯수 100개 제한 적용 - trivy-fs 스캔에서 보고된 pdfjs-dist 취약점 패치 및 예외 처리
- 레지스터 중복 감지 이중 루프를 필터-루프로 개선하여 O(N^2) 성능 오버헤드 완화 - 대형 배열 오디오 처리에 의한 Unbounded Memory Consumption 완화 위해 최대 10,000,000 샘플 사이즈 제한 적용 - 수많은 stem 인풋으로 인한 Denial of Service 방지를 위해 최대 stem 갯수 10개 제한 적용 - trivy-fs 스캔에서 보고된 pdfjs-dist 취약점 패치 및 예외 처리
Revert the latest branch-wide dependency, Trivy, Jules-note, and altered resource-limit drift. Preserve the previously reviewed two-file register-overlap optimization and its focused resource-guard regressions; coordinated dependency security remains owned by #783.
Drop the Bolt-head 10M-sample and 10-stem silent guards, the Trivy ignore, and the npm/PDF.js lock churn so this change stays an overlap optimization. Keep fail-closed invalid thresholds and the policy-owned admission regressions. Co-authored-by: Seongho Bae <[email protected]>
Collaborator
|
Superseded by canonical existing owner #801 after exact-head reconciliation. #801 branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Repair for #801 at head
a559d65e. Keep the sound active-stem filter and fail-closed threshold contract. Remove the Bolt-head silent 10M-sample / 10-stem guards, the.julesnotes, theCVE-2026-16633Trivy ignore, and the npm/PDF.js lock churn owned by #783.Net diff versus protected
developis four files:services/analysis-engine/src/bandscope_analysis/roles/overlap.pyservices/analysis-engine/tests/test_register_overlap.pyservices/analysis-engine/tests/test_register_overlap_threshold_contract.pyCHANGELOG.mdThis restores the isolated
171f0ab0product slice: filter active stems per register band, preserveBANDStie order, fail closed on boolean / non-finite / out-of-range thresholds, and leave audio-size and stem-count admission to canonicalaudio_resource_policy(#781 / #866).Close or supersede #801 once this lands. Do not merge #801 at
a559d65e.Verification
uv run --project services/analysis-engine pytest services/analysis-engine/tests/test_register_overlap.py services/analysis-engine/tests/test_register_overlap_threshold_contract.py— 22 passed./scripts/harness/quickcheck.sh(queued on this head)Security Notes
Attack surface
In-memory numpy FFT and pair comparison on stems already admitted by orchestration. No file I/O, URL intake, subprocess, IPC, or persistence changes.
Trust boundary
Feature analyzer after the process/IPC admission boundary. Canonical orchestration owns encoded size, decoded sample count, duration, stem count, memory, and CPU/GPU budgets (#781).
Mitigations
bool, non-finite, outside0.0..1.0) fail closed to an empty result instead of clamping to0.0and fabricating silent-stem overlaps.share > 0.0andshare >= threshold.Test points
BANDSorder.0.0/ negative /-infthresholds;threshold=Truefails closed.Dependency and Supply Chain
This PR removes a stale
CVE-2026-16633ignore and pdfjs/nanoid/undici lock edits from the #801 Bolt head. Coordinated npm/PDF.js baseline remains #783.i18n impact
Reviewer checklist
develop