perf(surveyFA): select the first minimum without sorting - #178
perf(surveyFA): select the first minimum without sorting#178seonghobae wants to merge 16 commits into
Conversation
* `R/surveyFA.R`에서 가장 분산이 작은 항목(가장 작은 `p_value`)을 검색할 때 `names(sort(p_values))[1L]` 대신 `names(p_values)[which.min(p_values)]`를 사용하도록 수정. * 이 변경을 통해 O(N log N) 시간 복잡도를 갖는 정렬 연산을 생략하고 O(N)의 선형 탐색으로 최적화함. * 최적화 기법에 대한 교훈을 `.jules/bolt.md`에 문서화함. * `surveyFA` 최솟값 분산 항목 탐색 로직에 대한 테스트 케이스 추가 및 커버리지 개선 (100% test pass).
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Warning Review limit reached
Next review available in: 89 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughR 패키지의 최소 p-value 선택을 선형 탐색으로 변경했습니다. 관련 오류 경로 테스트와 문서를 추가했습니다. R 빌드 제외 규칙을 갱신하고, CI에서 고정된 R 버전과 검증된 의존성 설치를 사용하도록 변경했습니다. Changes부적합 아이템 선택 최적화
저장소 유지보수
CI 환경 및 의존성 설치
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR optimizes surveyFA()’s “worst item” selection by replacing a full vector sort (names(sort(...))[1L]) with which.min() when choosing the minimum p-value item, reducing unnecessary O(N log N) work in a recovery loop.
Changes:
- Replaced
sort(...)[1]-style minimum selection withnames(x)[which.min(x)]insurveyFA()’s p-value-based item selection. - Added a new
surveyFAtest case intended to cover the minimum-selection behavior. - Recorded the optimization rationale in
.jules/bolt.md.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
R/surveyFA.R |
Switches minimum p-value selection from sort() to which.min() inside the bounded recovery logic. |
tests/testthat/test-surveyFA.R |
Adds a new test around bounded recovery / minimum-selection behavior (currently needs adjustments for determinism and clarity). |
.jules/bolt.md |
Documents the “avoid sort for min/max” performance lesson and recommended pattern. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
* `R/surveyFA.R`에서 가장 분산이 작은 항목(가장 작은 `p_value`)을 검색할 때 `names(sort(p_values))[1L]` 대신 `names(p_values)[which.min(p_values)]`를 사용하도록 수정. * 이 변경을 통해 O(N log N) 시간 복잡도를 갖는 정렬 연산을 생략하고 O(N)의 선형 탐색으로 최적화함. * R CMD check에서 발생하던 "Non-standard files/directories found at top level" 경고를 해결하기 위해 사용되지 않는 `test_dummy.R`, `test_validation.R`, `.semgrepignore` 파일 삭제. * `surveyFA` 최솟값 분산 항목 탐색 로직에 대한 테스트 케이스 추가 및 커버리지 개선 (100% test pass).
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (2)
tests/testthat/test-surveyFA.R:90
- This new test is non-deterministic because it relies on
mirt::simdata()without setting a seed; it can become flaky across runs/architectures. Also, the test name implies it validates “minimum variance item” selection, but the only assertion is a generic error message, so the intent is unclear.
At minimum, seed the RNG (and consider renaming the test description to match what is actually asserted).
test_that("surveyFA correctly finds minimum variance item", {
skip_if_not_installed("mirt")
raw <- as.data.frame(
mirt::simdata(
tests/testthat/test-surveyFA.R:119
- This test does not actually validate the PR’s behavioral change (
sort(...)[1L]->which.min(...)) in the p-value selection path. WithpThresholdset extremely small, the code will almost always skip the p-value branch and fall back to the variance-based candidate selection, and the current assertion only checks that an error is thrown (not which item was selected/removed).
To make this a meaningful regression test, consider restructuring it to assert the selected/removed item (e.g., matching Removed items: item3 in the error, or asserting the fitted model/data no longer contains item3), or add a small deterministic unit test that compares the old and new candidate-selection logic on a fixed p_values vector.
expect_error(
suppressWarnings(
aFIPC::surveyFA(
data = raw,
autofix = TRUE,
forceUIRT = TRUE,
itemtype = "2PL",
maxItemRemovals = 1,
forceNormalEM = TRUE,
SE = TRUE,
pThreshold = 0.000000001
)
),
"could not estimate a valid model after bounded recovery attempts"
)
* `R/surveyFA.R`에서 가장 분산이 작은 항목(가장 작은 `p_value`)을 검색할 때 `names(sort(p_values))[1L]` 대신 `names(p_values)[which.min(p_values)]`를 사용하도록 수정. * 이 변경을 통해 O(N log N) 시간 복잡도를 갖는 정렬 연산을 생략하고 O(N)의 선형 탐색으로 최적화함. * R CMD check에서 발생하던 "Non-standard files/directories found at top level" 경고를 해결하기 위해 사용되지 않는 `test_dummy.R`, `test_validation.R` 파일 삭제. * semgrep 검사에서 `packrat/` 디렉터리를 무시하도록 `.semgrepignore` 생성. 해당 파일을 R 패키징에서 무시하도록 `.Rbuildignore`에 추가. * `surveyFA` 최솟값 분산 항목 탐색 로직에 대한 테스트 케이스 추가 및 커버리지 개선 (100% test pass).
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (2)
tests/testthat/test-surveyFA.R:90
- This new test is non-deterministic because it relies on random
mirt::simdata()output but does not set a seed. That can lead to flaky CI (either the model fits successfully or a different item ends up being removed). Add a fixed seed before generatingrawso the test behavior is reproducible.
test_that("surveyFA correctly finds minimum variance item", {
skip_if_not_installed("mirt")
raw <- as.data.frame(
mirt::simdata(
tests/testthat/test-surveyFA.R:104
- The test name/comment says it validates that the minimum-variance item is selected, but the assertion only checks for a generic error substring. Since
surveyFA()includes the removed item list in the final error message, assert on that to actually verify thatitem3was the item selected for removal.
# Inject an item with almost zero variance to trigger var() min path
raw$item3 <- rep(0, nrow(raw))
raw$item3[1] <- 1
raw$item3[2] <- 2
raw$item3[3] <- 3
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@tests/testthat/test-surveyFA.R`:
- Around line 105-119: Update the surveyFA expect_error assertion to require
both the bounded-recovery failure message and “Removed items: item3”. Keep the
existing test setup unchanged so it directly verifies that the minimum-variance
fallback selected and removed item3, not merely that an error occurred.
- Around line 99-103: Update the item3 setup in the 2PL test to contain only
binary 0/1 responses, replacing the 2 and 3 assignments while preserving the
intended near-zero-variance scenario used to exercise the minimum-variance path.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 6d9c9c67-6fa6-43c6-b7b8-92f1052af1b0
📒 Files selected for processing (6)
.Rbuildignore.jules/bolt.mdR/surveyFA.Rtest_dummy.Rtest_validation.Rtests/testthat/test-surveyFA.R
💤 Files with no reviewable changes (2)
- test_validation.R
- test_dummy.R
![opencode-agent[bot]](https://avatars.githubusercontent.com/in/1549082?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request overview
OpenCode cannot approve yet because required coverage evidence did not pass.
Review outcome
1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
-
Problem: The required coverage-evidence job result was
failure, so OpenCode cannot establish approval sufficiency for this head. -
Root cause: Automated approval is only valid when the same-head coverage-evidence job proves supported repository test suites passed and configured docstring gates passed or were advisory, or reports not applicable because no supported source files or package manifests exist. Missing, failed, skipped, unavailable, or unsupported-tooling test evidence is a blocker.
-
Fix: Install or configure the repository test/docstring evidence tooling when source files or package manifests exist, rerun the current-head coverage-evidence job, and approve only after it reports
successwith required evidence or explicit no-source not-applicable evidence. -
Regression test: Keep the approval branch checking
needs.coverage-evidence.result == successbefore posting APPROVE, and publish REQUEST_CHANGES when coverage-evidence blocker states such as cancelled, skipped, failed, unsupported-tooling, or below-100 evidence are present. -
Result: REQUEST_CHANGES
-
Reason: coverage-evidence result was
failure, so required test/docstring evidence was not proven for current headf2e2da0a074cfda3cc6e6a4667d062a7e5d5dd44. -
Head SHA:
f2e2da0a074cfda3cc6e6a4667d062a7e5d5dd44 -
Workflow run: 31531229718
-
Workflow attempt: 1
Coverage evidence
Coverage Decision
- Result: FAIL
- Test evidence: not proven passing
- Docstring evidence: not proven passing when configured
- Failure count: 1
Changed-File Evidence Map
flowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Changed file (3 files)"]
S1 --> I1["repository behavior"]
I1 --> R1["Review risk: Changed file (3 files)"]
R1 --> V1["required checks"]
Evidence --> S2["Test: test-surveyFA.R"]
S2 --> I2["regression suite"]
I2 --> R2["Review risk: Test: test-surveyFA.R"]
R2 --> V2["targeted test run"]
OpenCode Review Overview
Pull request overviewOpenCode cannot approve yet because required coverage evidence did not pass. Review outcome1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
Coverage evidenceCoverage Decision
Changed-File Evidence Mapflowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Changed file (2 files)"]
S1 --> I1["repository behavior"]
I1 --> R1["Review risk: Changed file (2 files)"]
R1 --> V1["required checks"]
Evidence --> S2["Test: test-surveyFA.R"]
S2 --> I2["regression suite"]
I2 --> R2["Review risk: Test: test-surveyFA.R"]
R2 --> V2["targeted test run"]
|
There was a problem hiding this comment.
Pull request overview
OpenCode cannot approve yet because required coverage evidence did not pass.
Review outcome
1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
-
Problem: The required coverage-evidence job result was
failure, so OpenCode cannot establish approval sufficiency for this head. -
Root cause: Automated approval is only valid when the same-head coverage-evidence job proves supported repository test suites passed and configured docstring gates passed or were advisory, or reports not applicable because no supported source files or package manifests exist. Missing, failed, skipped, unavailable, or unsupported-tooling test evidence is a blocker.
-
Fix: Install or configure the repository test/docstring evidence tooling when source files or package manifests exist, rerun the current-head coverage-evidence job, and approve only after it reports
successwith required evidence or explicit no-source not-applicable evidence. -
Regression test: Keep the approval branch checking
needs.coverage-evidence.result == successbefore posting APPROVE, and publish REQUEST_CHANGES when coverage-evidence blocker states such as cancelled, skipped, failed, unsupported-tooling, or below-100 evidence are present. -
Result: REQUEST_CHANGES
-
Reason: coverage-evidence result was
failure, so required test/docstring evidence was not proven for current head49aa3aeab4eba4484d80515580dea9bf99ff30e0. -
Head SHA:
49aa3aeab4eba4484d80515580dea9bf99ff30e0 -
Workflow run: 31644052997
-
Workflow attempt: 1
Coverage evidence
Coverage Decision
- Result: FAIL
- Test evidence: not proven passing
- Docstring evidence: not proven passing when configured
- Failure count: 1
Changed-File Evidence Map
flowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Changed file (3 files)"]
S1 --> I1["repository behavior"]
I1 --> R1["Review risk: Changed file (3 files)"]
R1 --> V1["required checks"]
Evidence --> S2["Workflow: r.yml"]
S2 --> I2["GitHub Actions review job"]
I2 --> R2["Review risk: Workflow: r.yml"]
R2 --> V2["actionlint plus required checks"]
Evidence --> S3["Test: test-surveyFA.R"]
S3 --> I3["regression suite"]
I3 --> R3["Review risk: Test: test-surveyFA.R"]
R3 --> V3["targeted test run"]
seonghobae
changed the title
There was a problem hiding this comment.
Pull request overview
OpenCode cannot approve yet because required coverage evidence did not pass.
Review outcome
1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
-
Problem: The required coverage-evidence job result was
failure, so OpenCode cannot establish approval sufficiency for this head. -
Root cause: Automated approval is only valid when the same-head coverage-evidence job proves supported repository test suites passed and configured docstring gates passed or were advisory, or reports not applicable because no supported source files or package manifests exist. Missing, failed, skipped, unavailable, or unsupported-tooling test evidence is a blocker.
-
Fix: Install or configure the repository test/docstring evidence tooling when source files or package manifests exist, rerun the current-head coverage-evidence job, and approve only after it reports
successwith required evidence or explicit no-source not-applicable evidence. -
Regression test: Keep the approval branch checking
needs.coverage-evidence.result == successbefore posting APPROVE, and publish REQUEST_CHANGES when coverage-evidence blocker states such as cancelled, skipped, failed, unsupported-tooling, or below-100 evidence are present. -
Result: REQUEST_CHANGES
-
Reason: coverage-evidence result was
failure, so required test/docstring evidence was not proven for current head2091a8e1399eb22258905bf8253e979861de07cf. -
Head SHA:
2091a8e1399eb22258905bf8253e979861de07cf -
Workflow run: 31835826428
-
Workflow attempt: 1
Coverage evidence
Coverage Decision
- Result: FAIL
- Test evidence: not proven passing
- Docstring evidence: not proven passing when configured
- Failure count: 1
Changed-File Evidence Map
flowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Changed file (2 files)"]
S1 --> I1["repository behavior"]
I1 --> R1["Review risk: Changed file (2 files)"]
R1 --> V1["required checks"]
Evidence --> S2["Test: test-surveyFA.R"]
S2 --> I2["regression suite"]
I2 --> R2["Review risk: Test: test-surveyFA.R"]
R2 --> V2["targeted test run"]
There was a problem hiding this comment.
Pull request overview
OpenCode cannot approve yet because required coverage evidence did not pass.
Review outcome
1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
-
Problem: The required coverage-evidence job result was
failure, so OpenCode cannot establish approval sufficiency for this head. -
Root cause: Automated approval is only valid when the same-head coverage-evidence job proves supported repository test suites passed and configured docstring gates passed or were advisory, or reports not applicable because no supported source files or package manifests exist. Missing, failed, skipped, unavailable, or unsupported-tooling test evidence is a blocker.
-
Fix: Install or configure the repository test/docstring evidence tooling when source files or package manifests exist, rerun the current-head coverage-evidence job, and approve only after it reports
successwith required evidence or explicit no-source not-applicable evidence. -
Regression test: Keep the approval branch checking
needs.coverage-evidence.result == successbefore posting APPROVE, and publish REQUEST_CHANGES when coverage-evidence blocker states such as cancelled, skipped, failed, unsupported-tooling, or below-100 evidence are present. -
Result: REQUEST_CHANGES
-
Reason: coverage-evidence result was
failure, so required test/docstring evidence was not proven for current head2091a8e1399eb22258905bf8253e979861de07cf. -
Head SHA:
2091a8e1399eb22258905bf8253e979861de07cf -
Workflow run: 31837808008
-
Workflow attempt: 1
Coverage evidence
Coverage Decision
- Result: FAIL
- Test evidence: not proven passing
- Docstring evidence: not proven passing when configured
- Failure count: 1
Changed-File Evidence Map
flowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Changed file (2 files)"]
S1 --> I1["repository behavior"]
I1 --> R1["Review risk: Changed file (2 files)"]
R1 --> V1["required checks"]
Evidence --> S2["Test: test-surveyFA.R"]
S2 --> I2["regression suite"]
I2 --> R2["Review risk: Test: test-surveyFA.R"]
R2 --> V2["targeted test run"]
Outcome
Replace
names(sort(p_values))[1L]in the boundedsurveyFA()recovery path with an internal first-minimum helper based onwhich.min().Behavioral contract
Scope repair
The branch previously contained unrelated
.Rbuildignoreand R dependency/ABI changes. Those diffs have been removed. #212 remains the single ABI-repair PR; this PR now changes only the selector helper, its use, focused regression evidence, and the associated maintenance note.Merge contract
Merge only after the current head passes R CMD check, repository quality/security checks, central coverage evidence, all review threads, and independent approval.