feat(membership): emit estimation rows and refuse atomistic collapse - #54
Merged
seonghobae merged 7 commits intoAug 15, 2026
Merged
Conversation
One document keeps every active membership at an event time. Collapsing a known multiple-membership set into a single independent row fails closed. No new migration.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
seonghobae
marked this pull request as draft
August 13, 2026 12:30
6 tasks
seonghobae
marked this pull request as ready for review
August 14, 2026 13:40
seonghobae
marked this pull request as draft
August 15, 2026 06:05
seonghobae
marked this pull request as ready for review
August 15, 2026 09:40
seonghobae
changed the base branch from
main
to
maintenance/repair-base-b2a3f879
August 15, 2026 09:52
seonghobae
marked this pull request as draft
August 15, 2026 09:52
seonghobae
marked this pull request as ready for review
August 15, 2026 09:52
seonghobae
merged commit Aug 15, 2026
97f773c
into
maintenance/repair-base-b2a3f879
4 of 7 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#37–#53 remain review-blocked (no independent APPROVE). #37 and #45 kept ready. Next no-0008 gap: estimator-input rows in existing
membership_core(no new crate, no collision with #48/#49/#51/#53).estimation_rows_atemits one row per active membership2.0with computed RMSErefuse_atomistic_collapsedenies a one-row subset when multiplicity is 3Test plan
estimation_rows_contractfailed withE0432/E0599cargo test -p membership_core --offlinecargo clippy -p membership_core --all-targets --offline -- -D warningspython3 scripts/validate_documentation.pyandcheck_docstrings.pyDo not self-approve or merge. Prefer merge #37 then #45 when eligible. Do not allocate 0008.