Skip to content

feat(membership): emit estimation rows and refuse atomistic collapse - #54

Merged
seonghobae merged 7 commits into
maintenance/repair-base-b2a3f879from
agent/membership-estimation-rows
Aug 15, 2026
Merged

feat(membership): emit estimation rows and refuse atomistic collapse#54
seonghobae merged 7 commits into
maintenance/repair-base-b2a3f879from
agent/membership-estimation-rows

Conversation

@seonghobae

Copy link
Copy Markdown
Contributor

Summary

#37#53 remain review-blocked (no independent APPROVE). #37 and #45 kept ready. Next no-0008 gap: estimator-input rows in existing membership_core (no new crate, no collision with #48/#49/#51/#53).

  • estimation_rows_at emits one row per active membership
  • Known author+department+project weights recover total 2.0 with computed RMSE
  • refuse_atomistic_collapse denies a one-row subset when multiplicity is 3

Test plan

  • RED: estimation_rows_contract failed with E0432/E0599
  • cargo test -p membership_core --offline
  • cargo clippy -p membership_core --all-targets --offline -- -D warnings
  • python3 scripts/validate_documentation.py and check_docstrings.py
  • exact-head required Checks (do not treat queued evidence as passed)

Do not self-approve or merge. Prefer merge #37 then #45 when eligible. Do not allocate 0008.

One document keeps every active membership at an event time. Collapsing
a known multiple-membership set into a single independent row fails
closed. No new migration.
@coderabbitai

coderabbitai Bot commented Aug 13, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: c3c92ace-4227-4ce3-ace5-b341ed13afb9

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@seonghobae
seonghobae marked this pull request as ready for review August 14, 2026 13:40
@seonghobae
seonghobae marked this pull request as draft August 15, 2026 06:05
@seonghobae
seonghobae marked this pull request as ready for review August 15, 2026 09:40
@seonghobae
seonghobae changed the base branch from main to maintenance/repair-base-b2a3f879 August 15, 2026 09:52
@seonghobae
seonghobae marked this pull request as draft August 15, 2026 09:52
@seonghobae
seonghobae marked this pull request as ready for review August 15, 2026 09:52
@seonghobae
seonghobae merged commit 97f773c into maintenance/repair-base-b2a3f879 Aug 15, 2026
4 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant