feat(membership): refuse location as entity identity or language - #153
Draft
seonghobae wants to merge 1 commit into
Draft
feat(membership): refuse location as entity identity or language#153seonghobae wants to merge 1 commit into
seonghobae wants to merge 1 commit into
Conversation
Geographic and market assignments stay time-varying multiple-membership structure (ADR 0003). Location is not permanent entity identity and is not a language channel. Recovery is the computed share of location kinds that match known truth versus collapsing every assignment to entity identity.
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Geographic and market assignments stay time-varying multiple-membership structure (ADR 0003). Location is not permanent entity identity and is not a language channel. Recovery is the computed share of recovered kinds that match known truth versus collapsing every assignment to entity identity.
Complementary to #131 membership-target (entity/project/department/template/language/opportunity-pool/episode; location omitted) and #146 episode-interval containment. This crate owns location-versus-entity/language identity.
Local gates:
cargo test -p location_membership --all-targetsGREEN after RED (stub accepted every kind)-D warningsPASSDoes not allocate migration
0008. Does not touchpersistence_postgres(#113 collision). Does not recreate in-flight membership crates.Keep this PR draft. Preferred merge is now #48 only when exact-head required Checks pass and a qualifying independent APPROVE exists. Do not empty-commit #48. Re-draft #144 if it is undrafted.