Skip to content

feat(estimator): refuse a checkpoint as the CPU f64 estimator - #140

Draft
seonghobae wants to merge 1 commit into
mainfrom
agent/checkpoint-estimator-authority
Draft

feat(estimator): refuse a checkpoint as the CPU f64 estimator#140
seonghobae wants to merge 1 commit into
mainfrom
agent/checkpoint-estimator-authority

Conversation

@seonghobae

Copy link
Copy Markdown
Contributor

Summary

ADR 0001/0014 remaining buyer-visible scientific-authority increment: a model checkpoint is not the CPU f64 estimator. No new migration (0008 stays unallocated; #113 remains the entity/project SQL vehicle).

  • refuse_checkpoint_as_estimator fails closed when a model_checkpoint is treated as cpu_f64_estimator.
  • accept_checkpoint_artifact requires identity, model-run provenance, and canonical lowercase hex SHA-256; success does not grant estimator authority.
  • Recovery is the computed share of artifact roles that match known truth versus collapsing every artifact to the estimator.

Test plan

  • RED: checkpoint_authority_contract failed to compile (E0432) before the module existed
  • cargo test -p checkpoint_authority --offline (lib + 5 contract tests)
  • cargo clippy -p checkpoint_authority --all-targets --offline -- -D warnings
  • python3 scripts/check_docstrings.py / check_workspace_contract.py / validate_documentation.py
  • production lines 26/26 and nightly branches 18/18
  • cargo test --workspace --offline --lib --tests
  • exact-head required Checks on this PR (queued; do not treat as passed)

Do not self-approve or merge until exact-head required checks and a qualifying independent review pass. Keep this PR a draft. Do not empty-commit #46.

A model checkpoint remains an untrusted run artifact (ADR 0001/0014).
It cannot replace the reference estimator or promote a scientific claim.
Recovery is the computed share of artifact roles that match known truth
versus collapsing every artifact to the estimator.
@coderabbitai

coderabbitai Bot commented Aug 17, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: b8f00aa9-b572-4a25-bb4d-941d64ad0d21

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant