feat(estimator): refuse a checkpoint as the CPU f64 estimator - #140
Draft
seonghobae wants to merge 1 commit into
Draft
feat(estimator): refuse a checkpoint as the CPU f64 estimator#140seonghobae wants to merge 1 commit into
seonghobae wants to merge 1 commit into
Conversation
A model checkpoint remains an untrusted run artifact (ADR 0001/0014). It cannot replace the reference estimator or promote a scientific claim. Recovery is the computed share of artifact roles that match known truth versus collapsing every artifact to the estimator.
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ADR 0001/0014 remaining buyer-visible scientific-authority increment: a model checkpoint is not the CPU
f64estimator. No new migration (0008stays unallocated; #113 remains the entity/project SQL vehicle).refuse_checkpoint_as_estimatorfails closed when amodel_checkpointis treated ascpu_f64_estimator.accept_checkpoint_artifactrequires identity, model-run provenance, and canonical lowercase hexSHA-256; success does not grant estimator authority.Test plan
checkpoint_authority_contractfailed to compile (E0432) before the module existedcargo test -p checkpoint_authority --offline(lib + 5 contract tests)cargo clippy -p checkpoint_authority --all-targets --offline -- -D warningspython3 scripts/check_docstrings.py/check_workspace_contract.py/validate_documentation.pycargo test --workspace --offline --lib --testsDo not self-approve or merge until exact-head required checks and a qualifying independent review pass. Keep this PR a draft. Do not empty-commit #46.