Skip to content

feat(relation): refuse unobserved pairs as no-relationship - #132

Draft
seonghobae wants to merge 1 commit into
mainfrom
agent/relation-absence-not-negative
Draft

feat(relation): refuse unobserved pairs as no-relationship#132
seonghobae wants to merge 1 commit into
mainfrom
agent/relation-absence-not-negative

Conversation

@seonghobae

Copy link
Copy Markdown
Contributor

Summary

ADR 0003 remaining identity gate: observed, inferred, and unobserved relation statuses stay distinct. Unobserved pairs are missing statuses, not negative edges.

  • refuse_absence_as_negative fails closed on Unobserved.
  • Observed and inferred presence evidence stay typed and are not treated as absence.
  • Recovered statuses match known truth at a higher computed rate than collapsing every status to observed.
  • No new migration (0008 not allocated). Does not replace relation_graph.

Test plan

  • RED: absence_status_contract failed to compile (E0432) before the crate API existed
  • cargo test -p relation_absence --offline (lib + 2 contract tests)
  • cargo clippy -p relation_absence --all-targets --offline -- -D warnings
  • python3 scripts/check_workspace_contract.py / check_docstrings.py / validate_documentation.py
  • focused llvm-cov lines 14/14 and nightly branches 6/6
  • exact-head required Checks on this PR (queued; do not treat as passed)

Do not self-approve or merge until exact-head required checks and a qualifying independent review pass. Keep #46 ready; do not empty-commit it.

ADR 0003 remaining identity gate: observed, inferred, and unobserved
statuses stay distinct. Missing pairs never become negative evidence.
Recovered statuses beat collapsing every status to observed.
@coderabbitai

coderabbitai Bot commented Aug 17, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 4c728115-a6e9-48e5-92ad-7c980306df98

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant