feat(relation): refuse unobserved pairs as no-relationship - #132
Draft
seonghobae wants to merge 1 commit into
Draft
feat(relation): refuse unobserved pairs as no-relationship#132seonghobae wants to merge 1 commit into
seonghobae wants to merge 1 commit into
Conversation
ADR 0003 remaining identity gate: observed, inferred, and unobserved statuses stay distinct. Missing pairs never become negative evidence. Recovered statuses beat collapsing every status to observed.
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ADR 0003 remaining identity gate: observed, inferred, and unobserved relation statuses stay distinct. Unobserved pairs are missing statuses, not negative edges.
refuse_absence_as_negativefails closed onUnobserved.0008not allocated). Does not replacerelation_graph.Test plan
absence_status_contractfailed to compile (E0432) before the crate API existedcargo test -p relation_absence --offline(lib + 2 contract tests)cargo clippy -p relation_absence --all-targets --offline -- -D warningspython3 scripts/check_workspace_contract.py/check_docstrings.py/validate_documentation.pyDo not self-approve or merge until exact-head required checks and a qualifying independent review pass. Keep #46 ready; do not empty-commit it.