feat(membership): refuse customer-competitor overlap - #129
Draft
seonghobae wants to merge 1 commit into
Draft
Conversation
Customer, partner, and competitor remain contextual roles (ADR 0003). A customer/competitor pair in one group fails closed. Recovery is the computed share of role labels that match known truth versus collapsing every commercial role to customer.
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Customer, partner, and competitor remain time-varying contextual roles (ADR 0003). A customer/competitor pair in the same group fails closed. Partner may coexist with either role (coopetition or a customer-partner) without rewriting entity identity.
Recovery is the computed share of recovered role labels that match known truth versus collapsing every commercial role to customer. Empty or length-mismatched slices fail closed.
Local gates on
8981696:cargo test -p role_contradiction --all-targetsGREEN after RED (package did not exist)-D warningsPASSDoes not allocate migration
0008. Does not recreatemembership_core,citation_edge, clock crates, or other in-flight crates.Keep this PR draft. Preferred merge remains #45 only when exact-head required Checks pass and a qualifying independent (non-Cursor/CodeRabbit) APPROVE exists. Do not empty-commit #45.