test(mv3): prove bounded bookmark mutation compatibility by seonghobae · Pull Request #56 · ContextualWisdomLab/OriginWeave

seonghobae · 2026-08-10T19:04:37Z

Partial implementation of #27, stacked on live PR #43.

Buyer-visible gap

The pinned real-Chromium MV3 lane previously proved bookmark API visibility without proving a controlled mutation lifecycle. A defensible compatibility claim also needs one synthetic create/read/delete bookmark cycle without touching an ambient human profile.

Repaired live stack

Current exact prerequisite PR #43 head: c5e33b47b7a2ade47ecf962a41220b62c96a88db.
Current exact child head: 22bf82924f9bd254caf3bfa1db1891868c18a765.

The prior child 2e5984a405bdfe1e41647e8e75c7197559e7e8f6 had diverged after #43 advanced. The replacement tree was rebuilt from the exact current #43 tree and overlaid only the verified child semantic delta, then advanced non-destructively with the previous child as first parent and current #43 as second parent. Fresh comparison reports behind 0, merge base exactly the current prerequisite, and exactly three child-owned changed files:

tests/fixtures/mv3_basic/service_worker.js;
tests/test_mv3_bookmark_mutation_contract.py; and
tests/test_mv3_bookmarks_history_contract.py.

No prerequisite/predecessor check or review transfers.

Implemented boundary

The controlled fixture:

accepts only a parseable http://127.0.0.1/.../page.html sender with no embedded credentials;
creates one deterministic compatibility bookmark;
requires a non-empty returned bookmark identifier;
reads the exact bookmark back and verifies identifier, title and source URL;
removes the bookmark in finally cleanup and fails the evidence if cleanup fails;
retains separate history compatibility evidence; and
emits only readiness evidence, never exception text or ambient bookmark contents.

Exact-current evidence

On unchanged exact head 22bf82924f9bd254caf3bfa1db1891868c18a765 against exact prerequisite c5e33b47b7a2ade47ecf962a41220b62c96a88db:

ancestry: ahead, behind 0, merge base exactly the live prerequisite;
Manifest V3 Compatibility run 31979956308: success;
CI run 31979956373: success;
Rust contracts job 95245034398: repository contracts, formatting, workspace checks, full tests, strict Clippy and rustdoc success;
Production coverage job 95245034347: exact production coverage enforcement success;
exact-head checks consist of the successful Rust-contract, production-coverage and pinned-Chromium fixture checks; and
GitHub freshly reports the Draft mergeable.

Feature-base organization security/review workflows that did not execute are absent evidence and are not represented as passing.

Scope / governance

This is compatibility evidence only. It does not grant OriginWeave Agent bookmark authority, expose a general bookmark tool, mutate a human profile, add model calls, create persistence ownership, or complete the full issue #27 extension matrix. Chromium permission and browser compatibility remain separate from OriginWeave Agent capability/policy authority.

Keep Draft while #43 remains active. Protected-main AGENTS.md forbids this scheduled actor from merging, self-approving, altering workflows, adding secrets, weakening checks, tagging, or publishing.

coderabbitai · 2026-08-10T19:04:49Z

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 0cd3d1ee-4472-45c9-be55-d4c70423f1bf

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

…ycle

cursor

Stale comment

Review — PR #56 bookmark mutation

Verdict: the create → get → remove lifecycle is the right compatibility slice, and the pinned-Chromium MV3 fixture job on 82403ec already succeeded. This draft is still not merge-ready as an operator-actionable close.

What is sound

Mutation is bound to http://127.0.0.1/page.html without userinfo.

finally always attempts chrome.bookmarks.remove.

Raw _error.message is not retained.

Chrome bookmarks permission is not treated as an OriginWeave Agent grant.

Stacked draft on #43 / test/mv3-downloads is the correct dependency order.

What still blocks a buyer-visible close

Bookmark failures collapse to bookmarks: missing with no classified stage. Downloads already emit allow-listed tokens (download-source-rejected, download-complete-ready, …). Without the same contract here, an operator cannot tell source rejection from create failure, get mismatch, or leftover residue after remove fails.

The unique commit also omits the current chrome.bookmarks APA 7th primary citation that the downloads lane already requires.

Next action

Do not merge this draft while #43 is still the prerequisite and while bookmark failures stay unclassified. The diagnostic close is on cursor/bc-62f8754b-f579-4115-9089-cace87f78155-206a (054708a): allow-listed bookmark stage tokens, runner sanitization, and the current Bookmarks API citation. Keep #59/#60/#61 stacked behind that close. Compatibility success remains evidence only — not Agent bookmark authority.

Cannot approve: this identity authored the head. Formal approval stays with an eligible non-author reviewer if current rules require one; solo-maintainer independent-review remains on hold.

_{Sent by Cursor Automation: Fix Issues}

cursor · 2026-08-16T16:48:18Z

+      bookmarkMutationReady = false;
+    }
+  }
+  return bookmarkMutationReady;


This boolean return is the buyer-visible gap. A failed create, get mismatch, or failed remove all become bookmarks: missing with no classified stage. Mirror the downloads lane: return { ready, diagnostic } with allow-listed tokens such as bookmark-source-rejected, bookmark-create-rejected, bookmark-get-missing, bookmark-id-mismatch, bookmark-title-mismatch, bookmark-url-mismatch, bookmark-remove-rejected, and bookmark-complete-ready. Keep cleanup in finally, and if remove fails prefer bookmark-remove-rejected because leftover residue is the worse operator outcome. Do not copy _error.message, created.id, or node URLs into evidence.

cursor · 2026-08-16T16:48:18Z

+        ):
+            with self.subTest(expected=expected):
+                self.assertIn(expected, worker)
+


The contract currently proves string presence of create/get/remove only. Add the same runner sanitization the downloads lane already has: require bookmarksDiagnostic in SURFACE_EVIDENCE_KEYS, allow-list the stage tokens, and prove that a raw Chrome error or the fixture bookmark title is reduced to unexpected before it can enter trial evidence.

cursor

Review — exact head `cea76b9e129d02a093ae237804e47ee3a4a08a6c`

The new commit only realigns this draft with the downloads transport-protocol classification. The buyer-visible diagnostic gap is unchanged: exerciseBookmarkMutation still returns a boolean, so create failure, get mismatch, and leftover residue after remove all collapse to bookmarks: missing.

Prior threads remain not addressed on this head:

allow-listed bookmark stage tokens (bookmark-source-rejected … bookmark-complete-ready)
runner sanitization of bookmarksDiagnostic (raw Chrome errors / fixture titles → unexpected)
current chrome.bookmarks APA 7th primary citation

Pinned Chrome for Testing MV3 fixture already succeeded on this head. Rust contracts and Production coverage were still in progress at review time and are not treated as passing.

Next action

Do not merge this draft. Keep #43 as the downloads prerequisite. The diagnostic close is #178 44cbfc2 (test(mv3): require bounded bookmark mutation diagnostics). Do not open a third bookmark-diagnostic pull request. Keep #59/#60/#61 stacked behind that close. Compatibility success is not OriginWeave Agent bookmark authority.

Cannot approve: this identity authored the head. Formal approval stays with an eligible non-author reviewer if current rules require one; solo-maintainer independent-review remains on hold.

_{Sent by Cursor Automation: Fix Issues}

cursor · 2026-08-16T16:55:48Z

+      bookmarkMutationReady = false;
+    }
+  }
+  return bookmarkMutationReady;


Unchanged on cea76b9. A failed create, get mismatch, and failed remove still all become bookmarks: missing. Keep the close on #178: return { ready, diagnostic } with allow-listed tokens, prefer bookmark-remove-rejected when cleanup fails, and never copy _error.message, created.id, or node URLs into evidence.

cursor · 2026-08-16T16:55:48Z

+        ):
+            with self.subTest(expected=expected):
+                self.assertIn(expected, worker)
+


Still string-presence only. #178 is the landing for bookmarksDiagnostic in SURFACE_EVIDENCE_KEYS, allow-listed stage tokens, and proof that a raw Chrome error or the fixture bookmark title is reduced to unexpected.

Preserve the current bookmark diagnostic tree while adding exact ancestry to PR #56 head 71420d0. The diagnostic branch already contains the bookmark mutation lifecycle plus the same hardened downloads-root changes; this non-destructive merge repairs stack topology without transferring predecessor checks or reviews.

Rebuild the diagnostic lane on the exact current PR #56 tree while preserving the bounded bookmark diagnostic source/test delta. Keep the prerequisite ChromeDriver cleanup resilience and extension-authority hardening, retain the dedicated MV3 doctoring evidence, and avoid reintroducing duplicate/stale generic doctoring/TRD claims. No predecessor check or review evidence transfers.

test(mv3): require real bookmark mutation lifecycle

c9a4a80

seonghobae added 2 commits August 11, 2026 04:06

test(mv3): exercise bounded bookmark mutation

50111a8

test(mv3): align bookmarks compatibility contract with mutation lifec…

e1099e3

…ycle

seonghobae changed the title ~~test(mv3): prove bookmark mutation compatibility~~ test(mv3): prove bounded bookmark mutation compatibility Aug 10, 2026

seonghobae added 8 commits August 15, 2026 18:13

merge: align MV3 bookmark mutation with current prerequisite

495ea67

merge: align MV3 bookmark mutation with current prerequisite

5d93647

test(mv3): preserve restart-safe download prerequisite

49cfb55

fix(mv3): preserve restart-safe download behavior

18ebb7f

merge: align bookmark mutation with current MV3 download prerequisite

83df60f

merge: realign bookmark mutation with cleanup-safe MV3 root

857134a

test(mv3): inherit cleanup import normalization

369cb5d

merge: realign bookmark mutation to current downloads prerequisite

6a98045

This was referenced Aug 16, 2026

feat(core): refuse Chrome downloads as Agent download #175

Open

test(mv3): prove real downloads compatibility #43

Open

fix(mv3): classify click postcondition mismatches #176

Closed

chore(mv3): align bookmark mutation with current downloads prerequisite

82403ec

cursor Bot reviewed Aug 16, 2026

View reviewed changes

cursor Bot mentioned this pull request Aug 16, 2026

test(mv3): require bounded bookmark mutation diagnostics #178

Draft

chore(mv3): align bookmark mutation with transport fix

cea76b9

cursor Bot reviewed Aug 16, 2026

View reviewed changes

test(mv3): realign bookmark mutation to hardened downloads root

71420d0

seonghobae added 2 commits August 17, 2026 05:44

merge: align bookmark mutation with current MV3 prerequisite

2e5984a

chore(mv3): realign bookmark mutation with current downloads head

22bf829

Navigation Menu

Uh oh!

test(mv3): prove bounded bookmark mutation compatibility - #56

test(mv3): prove bounded bookmark mutation compatibility#56
seonghobae wants to merge 16 commits into
test/mv3-downloadsfrom
test/mv3-bookmark-mutation

seonghobae commented Aug 10, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Aug 10, 2026 •

edited

Loading

Review skipped

Uh oh!

cursor Bot left a comment •

edited

Loading

Uh oh!

cursor Bot Aug 16, 2026

Uh oh!

cursor Bot Aug 16, 2026

Uh oh!

cursor Bot left a comment

Uh oh!

cursor Bot Aug 16, 2026

Uh oh!

cursor Bot Aug 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

seonghobae commented Aug 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Buyer-visible gap

Repaired live stack

Implemented boundary

Exact-current evidence

Scope / governance

Uh oh!

coderabbitai Bot commented Aug 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

cursor Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Review — PR #56 bookmark mutation

What is sound

What still blocks a buyer-visible close

Next action

Uh oh!

cursor Bot Aug 16, 2026

Choose a reason for hiding this comment

Uh oh!

cursor Bot Aug 16, 2026

Choose a reason for hiding this comment

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Review — exact head cea76b9e129d02a093ae237804e47ee3a4a08a6c

Next action

Uh oh!

cursor Bot Aug 16, 2026

Choose a reason for hiding this comment

Uh oh!

cursor Bot Aug 16, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

seonghobae commented Aug 10, 2026 •

edited

Loading

coderabbitai Bot commented Aug 10, 2026 •

edited

Loading

cursor Bot left a comment •

edited

Loading

Review — exact head `cea76b9e129d02a093ae237804e47ee3a4a08a6c`