Skip to content

fix(evidence): expose standard evidence error contract - #157

Open
seonghobae wants to merge 4 commits into
mainfrom
fix/evidence-error-contract
Open

fix(evidence): expose standard evidence error contract#157
seonghobae wants to merge 4 commits into
mainfrom
fix/evidence-error-contract

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Buyer/reliability gap

originweave-evidence::EvidenceError is a public validation failure type used by network and provenance evidence construction, but protected main 0c376acf059be9ddddddfbde1d0189e4f39ef014 does not implement Rust Display / std::error::Error for it. Callers therefore cannot render or chain this stable typed failure through ordinary Rust error boundaries without special-case matching.

Test-first evidence

This PR is based directly on protected main 0c376acf059be9ddddddfbde1d0189e4f39ef014.

  • Test-only head 70b900d337be10ee6fa5b2fbbca2c4b9a65b0142 first failed only at cargo fmt --check, so that run was not accepted as RED.
  • Formatting-only head b951f6863a4abc1308ebada86299f8a0a341def8 reached the intended compile boundary: the new integration test could not call to_string() or Error::source() because EvidenceError lacked Display and std::error::Error. This is the valid RED.
  • Production head f151c24ec4bd6206891236f574d9c1063d9594d0 added only deterministic credential-safe Display text for the five existing variants plus impl std::error::Error for EvidenceError {}. Exact-head Rust contracts and production coverage both passed, including the repository's exact owned production function/line/region/branch coverage gate.
  • Current exact head ab90ff5013bf1dfa4002de17816cafe3b86f156a adds the required canonical changelog entry. Exact-current-head CI run 31825085853, SAST Semgrep run 31825085856, and Security Scan run 31825085880 are all completed successfully.

The regression also requires Error::source() to remain empty for every current variant.

Scope boundary

This lane changes no evidence validation rule, redaction behavior, network capture, provenance data, persistence, retention, policy, workflow, or secret handling. The production remedy is limited to the standard Rust error contract for the existing five public variants.

Live review state

This PR is Ready for review and mergeable on exact head ab90ff5013bf1dfa4002de17816cafe3b86f156a. There are currently no formal reviews or unresolved review threads. Passing automation is not independent approval; protected-main governance still requires an eligible independent approval and latest-push approval, and the scheduled actor does not merge or self-approve.

@coderabbitai

coderabbitai Bot commented Aug 14, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 13 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: c4d624c2-ce35-4b07-8564-e9b16d77bc14

📥 Commits

Reviewing files that changed from the base of the PR and between 0c376ac and ab90ff5.

📒 Files selected for processing (3)
  • CHANGELOG.md
  • crates/originweave-evidence/src/lib.rs
  • crates/originweave-evidence/tests/error_contract.rs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant