fix(resource): expose standard budget error contract - #156
Conversation
|
Warning Review limit reached
Next review available in: 59 minutes Limit details: You’ve used all 1 included review currently available under your plan. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
Buyer/reliability gap
originweave-resource::BudgetErroris a public failure type, but protected main did not implement the standard RustDisplay/std::error::Errorcontract. Resource-governor callers therefore had to special-case validation failures instead of preserving typed context through ordinary Rust integration boundaries.TDD lineage
This branch starts directly from protected main
0c376acf059be9ddddddfbde1d0189e4f39ef014.Exact test-only head
fe871b17d07a3a08592144384a780775b7b88526required deterministic credential-free messages for both currentBudgetErrorvariants and requiredError::source()to remain empty before production support existed. The production remedy adds only exhaustiveDisplayplus source-freestd::error::Error.Current implementation
Exact head
d9166d89f154962af7a6b2b7902ff3b2c4579606:ZeroLimitas a deterministic non-secret operator message;SoftExceedsHardas a deterministic non-secret operator message;std::error::Errorwithout fabricating a nested source;The exact diff is limited to the resource crate, its focused public integration regression, and the canonical changelog line.
Exact-head verification
On unchanged exact head
d9166d89f154962af7a6b2b7902ff3b2c4579606against exact protected main0c376acf059be9ddddddfbde1d0189e4f39ef014:31823695097: success;94842723654: repository contracts, formatting, locked workspace/all-target checks, full tests, strict Clippy, and rustdoc success;94842723607: exact owned-production function, line, region, and branch coverage enforcement success;31823695066: success;31823695031: success;No predecessor-head, queued, skipped, synthetic, or model-only result is promoted as current proof.
Scope boundary
This changes no resource limits, pressure classification, governor decisions, telemetry, process attribution, persistence, workflow, or release behavior. Passing automation is not independent approval; protected integration remains subject to the live ruleset and unchanged-head review evidence.