Skip to content

chore: retain duplicate Milestone 2 provenance prototype as slice-2 evidence - #86

Closed
seonghobae wants to merge 21 commits into
feat/related-node-person-side-labels-v078from
feat/milestone2-analysis-run-contract-v079
Closed

chore: retain duplicate Milestone 2 provenance prototype as slice-2 evidence#86
seonghobae wants to merge 21 commits into
feat/related-node-person-side-labels-v078from
feat/milestone2-analysis-run-contract-v079

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 15, 2026

Copy link
Copy Markdown
Contributor

Duplicate and superseded by the canonical registry

PR #83 is the canonical first Milestone 2 persistence slice. It predates this PR, is stacked directly on the protected post-#74 product line, and exclusively owns migration ordinal 0018, ADR number 0013, source-capture clocks, account-scoped idempotency, authorization scope, immutable aggregate evidence, fail-closed rollback, and ordered run lifecycle.

This branch independently introduces another 0018 migration, another ADR 0013, and incompatible source/run/status relations. Merging both would create two authorities for the same product facts and an unreconcilable migration/ADR collision. Its temporary verification workflow also expands the duplicate lane rather than resolving that ownership conflict.

The non-overlapping implementation evidence remains valuable and is preserved on this branch for a later bounded slice after #83 reaches its final verified schema:

  • exact source-safe and canonical request hashing;
  • Python evidence, completion, and public-summary contracts;
  • transactional conditional-upsert and immutable-conflict handling;
  • idempotent start-event reuse;
  • source-redacting read projections;
  • TEPP/contextual-orchestrator/fast-mlsirm service-run records and external-artifact references, after their normalized lifecycle and retention contracts are separately reviewed.

That follow-up must consume #83's final table, clock, scope, lookup, idempotency, immutability, and rollback vocabulary. It must not carry this branch's competing migration, ADR number, or temporary workflow.

Closing this duplicate without deleting its branch or TDD evidence.

Superseded by #83. Part of #79.

@coderabbitai

coderabbitai Bot commented Aug 15, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 2cd4bc63-f12f-4baf-b47d-c99a6882ea38

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@seonghobae seonghobae changed the title feat: persist Milestone 2 analysis-run provenance (v0.79.0) chore: retain duplicate Milestone 2 provenance prototype as slice-2 evidence Aug 15, 2026
@seonghobae seonghobae closed this Aug 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant