fix: retain partial visual regions - #320
Conversation
|
@opencode-agent review exact current HEAD 34a0c98. Inspect partial visual-region retention, parent-image fallback, region status persistence, and current required Checks. Report actionable findings only; do not approve, bypass, or use stale parent evidence. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@opencode-agent review exact current HEAD 799671a. Re-check partial visual-region retention, parent-image fallback, region status persistence, and current required Checks. Prior-head evidence is stale; report actionable findings only and do not approve or bypass. |
|
@opencode-agent review exact current HEAD 41d164c5c0c312b66982f8cf8c4c14f16ab7f80f. Re-check the partial visual-region and parent-failure paths plus current required Checks; prior-head evidence is stale. Report findings only; do not approve or bypass. |
|
@opencode-agent review exact current HEAD 41d164c. Re-check the partial visual-region and parent-failure paths plus current required Checks; prior-head evidence is stale. Report findings only; do not approve or bypass. |
|
Review exact current HEAD 41d164c. This is the dependency base for the visual-region validation stack; its required Full test suite and Frontend lint, test, build checks are green. Please publish a formal independent review for this exact SHA and confirm the base-chain relationship before merge. |
…mantics' into codex/preserve-partial-image-regions # Conflicts: # docs/product-technical-gap-baseline.md # lineageweave/post_content_normalization.py # tests/test_post_content_normalization.py
|
Review exact current HEAD |
…mantics' into codex/preserve-partial-image-regions
…mantics' into codex/preserve-partial-image-regions
|
Reviewed and repaired against exact current head
PR #324 remains the stacked follow-up for finite/in-bounds region validation. This PR remains blocked pending independent formal review and terminal Checks; no bypass used. |
…mantics' into codex/preserve-partial-image-regions
…mantics' into codex/review-pr320 # Conflicts: # docs/adr/0104-partial-visual-regions-retain-parent-evidence.md # docs/product-technical-gap-baseline.md # lineageweave/post_content_normalization.py # tests/test_post_content_normalization.py
Buyer-visible gap
A VISION locator that returned valid salient panels but not full-image coverage
was replaced by one full-image region. Panel coordinates, panel-level OCR, and
panel search attribution were therefore lost.
Change
evidence outside the panels.
output without inventing a region coordinate.
retention, parent analysis, and no fabricated full-image region.
Verification
e84994e9145d3f7a1a7849e94c91de02cccf62fc.0f8bc28f116dc4c6e3a04c01d042de53c51e9173after an ordinary parentrestack.
uv run --locked --extra dev --extra backend python -m pytest -q—734 passed, 16 skipped, 4 warnings.13 passed.136tests, production build, Storybook,actionlint, andgit diff --checkpassed.No real records, identifiers, or provider credentials are included. This PR
is stacked on #319, which is stacked on #317.