Skip to content

fix: retain partial visual regions - #320

Open
seonghobae wants to merge 12 commits into
codex/normalize-source-indent-semanticsfrom
codex/preserve-partial-image-regions
Open

fix: retain partial visual regions#320
seonghobae wants to merge 12 commits into
codex/normalize-source-indent-semanticsfrom
codex/preserve-partial-image-regions

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Buyer-visible gap

A VISION locator that returned valid salient panels but not full-image coverage
was replaced by one full-image region. Panel coordinates, panel-level OCR, and
panel search attribution were therefore lost.

Change

  • Retain every valid bounded partial region.
  • Analyze the parent image once when locator coverage is partial, preserving
    evidence outside the panels.
  • Keep parent-image evidence for empty, invalid, or single full-image locator
    output without inventing a region coordinate.
  • Record the contract in ADR 0104 and add regressions asserting panel
    retention, parent analysis, and no fabricated full-image region.

Verification

  • Current parent fix: keep visual whitespace out of authoritative structure #319:
    e84994e9145d3f7a1a7849e94c91de02cccf62fc.
  • Current head:
    0f8bc28f116dc4c6e3a04c01d042de53c51e9173 after an ordinary parent
    restack.
  • uv run --locked --extra dev --extra backend python -m pytest -q
    734 passed, 16 skipped, 4 warnings.
  • Focused image/normalization tests — 13 passed.
  • Frontend lint, TypeScript build, 136 tests, production build, Storybook,
    actionlint, and git diff --check passed.

No real records, identifiers, or provider credentials are included. This PR
is stacked on #319, which is stacked on #317.

@seonghobae

Copy link
Copy Markdown
Contributor Author

@opencode-agent review exact current HEAD 34a0c98. Inspect partial visual-region retention, parent-image fallback, region status persistence, and current required Checks. Report actionable findings only; do not approve, bypass, or use stale parent evidence.

@coderabbitai

coderabbitai Bot commented Aug 20, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 1765230d-eb16-41c3-a118-e1b33b149f5d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@seonghobae

Copy link
Copy Markdown
Contributor Author

@opencode-agent review exact current HEAD 799671a. Re-check partial visual-region retention, parent-image fallback, region status persistence, and current required Checks. Prior-head evidence is stale; report actionable findings only and do not approve or bypass.

@seonghobae

Copy link
Copy Markdown
Contributor Author

@opencode-agent review exact current HEAD 41d164c5c0c312b66982f8cf8c4c14f16ab7f80f. Re-check the partial visual-region and parent-failure paths plus current required Checks; prior-head evidence is stale. Report findings only; do not approve or bypass.

@seonghobae

Copy link
Copy Markdown
Contributor Author

@opencode-agent review exact current HEAD 41d164c. Re-check the partial visual-region and parent-failure paths plus current required Checks; prior-head evidence is stale. Report findings only; do not approve or bypass.

@seonghobae

Copy link
Copy Markdown
Contributor Author

Review exact current HEAD 41d164c. This is the dependency base for the visual-region validation stack; its required Full test suite and Frontend lint, test, build checks are green. Please publish a formal independent review for this exact SHA and confirm the base-chain relationship before merge.

…mantics' into codex/preserve-partial-image-regions

# Conflicts:
#	docs/product-technical-gap-baseline.md
#	lineageweave/post_content_normalization.py
#	tests/test_post_content_normalization.py

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

@seonghobae

Copy link
Copy Markdown
Contributor Author

Review exact current HEAD 0f8bc28f116dc4c6e3a04c01d042de53c51e9173. Re-check partial visual-region retention, parent-image fallback, region status persistence, and the current required Checks; prior-head evidence is stale. Please publish a formal independent review for this exact SHA and report actionable findings only.

@seonghobae

Copy link
Copy Markdown
Contributor Author

Reviewed and repaired against exact current head 91a95a976c406a6e9d96c943b74d68e6a1b5cdc7 (including concurrent upstream synchronization commits):

  • Partial locator regions remain independently described and the original parent image is still described for uncovered content.
  • A malformed non-iterable locator result now falls back to parent-image evidence instead of incorrectly failing the entire image.
  • Added a regression test for that provider-boundary case.
  • Focused verification: uv run --locked --extra dev --extra backend python -m pytest -q tests/test_post_content_normalization.py tests/test_image_content.py tests/test_post_content_persistence_edges.py51 passed.
  • git diff --check passes.

PR #324 remains the stacked follow-up for finite/in-bounds region validation. This PR remains blocked pending independent formal review and terminal Checks; no bypass used.

@seonghobae
seonghobae enabled auto-merge (squash) August 21, 2026 05:04
@seonghobae seonghobae added the bug Something isn't working label Aug 21, 2026 — with ChatGPT Codex Connector
…mantics' into codex/review-pr320

# Conflicts:
#	docs/adr/0104-partial-visual-regions-retain-parent-evidence.md
#	docs/product-technical-gap-baseline.md
#	lineageweave/post_content_normalization.py
#	tests/test_post_content_normalization.py
devin-ai-integration[bot]

This comment was marked as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant