fix: retrieve Global Ask semantic evidence (v2.18.1) - #268
Draft
seonghobae wants to merge 5 commits into
Draft
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
seonghobae
changed the base branch from
agent/authenticated-global-ask-mcp-v2180
to
agent/authenticated-mcp-global-ask
August 19, 2026 23:05
seonghobae
changed the base branch from
agent/authenticated-mcp-global-ask
to
agent/authenticated-global-ask-mcp-v2180
August 19, 2026 23:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Buyer Gap
Global Ask already carries persisted project, role/responsibility/affiliation, and cataloged Keyman facts after a post has been selected. Its shared candidate assembler still searches title/body and raw
source_posthints only.A browser buyer or authenticated MCP client can therefore see a project, owner, responsibility, affiliation, or Keyman in evidence, ask with that exact semantic fact, and receive no citation when those words are absent from raw source text.
Fix
This Draft keeps the bounded semantic-candidate RED→GREEN patch and index contract. It remains temporarily based on the closed #265 branch only as a code ancestry bridge; #265 is not a merge prerequisite and its hand-rolled MCP transport is not canonical.
Canonicalization gate
#270 is the canonical MCP Global Ask implementation. Before this PR can leave Draft, rebase/reconstruct the semantic-only retrieval delta onto the then-current #270 head, prove the diff is limited to semantic candidate retrieval/indexing/docs/tests, and regenerate all exact-head evidence. Do not transfer #265 checks, reviews, version claims, or transport code.
The Buyer-surface prerequisite chain remains
#258 → #260 → #261 → #262 → #263 → #264.Non-claims
No embedding-similarity, exhaustive-recall, causal-inference, unsupported-answer, historical-cutoff, or TEPP-result claim is added.