Skip to content

feat: name leftover criterion on the matching Keyman chip (v0.92.0) - #256

Closed
seonghobae wants to merge 1 commit into
mainfrom
feat/name-leftover-on-keyman-chip-v0920
Closed

feat: name leftover criterion on the matching Keyman chip (v0.92.0)#256
seonghobae wants to merge 1 commit into
mainfrom
feat/name-leftover-on-keyman-chip-v0920

Conversation

@seonghobae

Copy link
Copy Markdown
Contributor

Buyer impact

After make seed, open the leftover Public post. Ada West reads Closest leftover · sales-lead. Click still opens related nodes. A related leftover post chip reads Farthest leftover · negative; click still opens that post. A chip that is not a leftover pair stays unmarked.

Leftover buttons above the member list stay (ADR 0018). This slice only labels the already-visible Keyman chips so a buyer who follows leftover into Keyman still sees the leftover criterion. Existing accessible names (Related nodes for {name}, Open related post: {title}) are unchanged.

Scope

  • Authorized leftover_pairs already on the period-report payload mark Keyman chips on that leftover post and related-post chips that are leftover pairs (ADR 0033).
  • Visible leftover caption only. Do not invent leftover on a person. Do not invent a fused score or a theta.
  • A report fetch error clears leftover captions and leaves the Keyman list intact — never an invented pair.

Exact head

00393f310936a1c379aa7f78ab64ed7b83acf494 on feat/name-leftover-on-keyman-chip-v0920.

Base: main @ 8c020aa (merged #220 RankWeave).

Frontend: 49 tests, oxlint clean.

Review gate

Not in this slice

Leftover persist+list landed as #211. Event Lineage leftover is #255. Home-row leftover is #254. Calendar leftover is #253. Rankings leftover is #252. Member leftover is #234.

References

Jeon, M., Jin, I. H., Schweinberger, M., & Baugh, S. (2021). Mapping unobserved item–respondent interactions: A latent space item response model with interaction map. Psychometrika, 86(2), 378–403.

After make seed, Ada West on the leftover Public post reads Closest leftover · sales-lead. A related leftover post chip reads Farthest leftover · negative. Click still opens related nodes or that post. Never invent a fused score or a theta.

Copy link
Copy Markdown
Contributor Author

Cycle 2026-08-18T20:00 KST write-retry after open.

Exact head 00393f310936a1c379aa7f78ab64ed7b83acf494. Independent exact-head APPROVE required. Owner/self COMMENT is not APPROVE. Do not self-approve. Do not squash from this author. Do not mix into #74/#92.

Frontend: 49 tests, oxlint clean. Next leftover surface after Keyman chips is affiliate tree.

@coderabbitai

coderabbitai Bot commented Aug 18, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 52 minutes

Limit details: You’ve used all 1 included review currently available under your plan.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 3a732d77-39ac-4eef-9585-07a6f54f795d

📥 Commits

Reviewing files that changed from the base of the PR and between 8c020aa and 00393f3.

⛔ Files ignored due to path filters (1)
  • uv.lock is excluded by !**/*.lock
📒 Files selected for processing (13)
  • AGENTS.md
  • ARCHITECTURE.md
  • CHANGELOG.d/0.92.0-leftover-keyman-chip.md
  • CHANGELOG.md
  • docs/adr/0033-leftover-pair-on-keyman-chip.md
  • frontend/package.json
  • frontend/src/App.css
  • frontend/src/App.test.tsx
  • frontend/src/App.tsx
  • frontend/src/leftoverCaption.test.ts
  • frontend/src/leftoverCaption.ts
  • lineageweave/__init__.py
  • pyproject.toml

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Contributor Author

Closing to prevent an atomistic/misattributed interpretation. A leftover relation is between a specific post/respondent representation and a criterion under one fitted report model; it is not a property of the Keyman person, the related person node, or the post chip in general. This branch propagates ambient report state onto person-centered UI and can make a model residual look like an observed characteristic of an individual. Canonical #258 keeps the pair in the report that owns its model and evidence. Any future navigation must carry the exact report/run and state explicitly that the label belongs to the post–criterion pair, never the person. Closing without merge.

@seonghobae seonghobae closed this Aug 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant