-
Notifications
You must be signed in to change notification settings - Fork 0
feat: name leftover criterion on an accepted Rankings hit (v0.88.0) #252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| # 0.88.0 — Leftover badge on an accepted Rankings hit | ||
|
|
||
| ## Added | ||
|
|
||
| - Accepted Rankings hits that are leftover pairs name the leftover | ||
| criterion (ADR 0029). After `make seed` with RankWeave accepted, | ||
| the leftover hit reads **Closest leftover · sales-lead** next to | ||
| rank; click opens that post. Unavailable Rankings stay fail-closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| # ADR 0029 — Name leftover on an accepted Rankings hit | ||
|
|
||
| **Decision status:** Accepted | ||
| **Date:** 2026-08-18 | ||
|
|
||
| ## Context | ||
|
|
||
| ADR 0024 lists accepted RankWeave hits above Calendar. ADR 0018 puts | ||
| leftover pairs above the period-report member list. A buyer who starts | ||
| from Rankings still sees only title and fused rank. The leftover post | ||
| is already in that list when RankWeave accepts it; the hit just does | ||
| not name the leftover criterion. | ||
|
|
||
| Do not invent a second leftover store. Do not invent a fused score or | ||
| a theta. Unavailable Rankings stay **Rankings · RankWeave not | ||
| available**. | ||
|
|
||
| ## Decision | ||
|
|
||
| When an authorized leftover pair names an accepted ranking hit, that | ||
| button shows `Closest leftover · {criterion}` or | ||
| `Farthest leftover · {criterion}` and includes the same caption in | ||
| its accessible name. | ||
|
|
||
| A hit that is not a leftover pair stays unmarked. A leftover pair | ||
| for a hidden post never reaches Rankings (ADR 0017 ABAC plus ADR | ||
| 0024 hidden-post omit). RankWeave unavailability still renders no | ||
| hits. | ||
|
|
||
| After `make seed` with RankWeave accepted, the leftover ranking hit | ||
| reads **Closest leftover · sales-lead** next to rank; click still | ||
| opens that post. | ||
|
|
||
| Leftover evidence is the same authorized `leftover_pairs` already | ||
| on the period-report payload. A report fetch error clears the list | ||
| — never an invented pair. | ||
|
|
||
| ## Consequences | ||
|
|
||
| Leftover buttons above the member list stay (ADR 0018). Member | ||
| badges stay on #234 / ADR 0028. Comparison-strip leftover is #233. | ||
| Opened-post leftover copy is #224. This slice only labels the | ||
| already-visible ranking hit. | ||
|
|
||
| ## Related | ||
|
|
||
| Depends on [ADR 0017](0017-persist-lsirm-leftover-pairs.md), | ||
| [ADR 0018](0018-leftover-pair-report-ui.md), and | ||
| [ADR 0024](0024-rankweave-fusion-fail-closed.md). | ||
|
|
||
| ## References | ||
|
|
||
| Jeon, M., Jin, I. H., Schweinberger, M., & Baugh, S. (2021). Mapping | ||
| unobserved item–respondent interactions: A latent space item response | ||
| model with interaction map. *Psychometrika, 86*(2), 378–403. | ||
| https://doi.org/10.1007/s11336-021-09762-5 | ||
|
|
||
| Cormack, G. V., Clarke, C. L. A., & Buettcher, S. (2009). Reciprocal | ||
| rank fusion outperforms condorcet and individual rank learning | ||
| methods. In *Proceedings of the 32nd international ACM SIGIR | ||
| conference on Research and development in information retrieval* | ||
| (pp. 758–759). ACM. https://doi.org/10.1145/1571941.1572114 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -35,4 +35,4 @@ | |
| "sentence_excerpts", | ||
| ] | ||
|
|
||
| __version__ = "0.75.0" | ||
| __version__ = "0.88.0" | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
알 수 없는
pair_kind를Closest leftover로 표시하지 마세요.LeftoverPair.pair_kind는 임의의 문자열을 허용합니다. 현재 구현은"farthest"가 아닌 모든 값을"Closest leftover"로 변환합니다. 새 값이나 잘못된 값이 들어오면 Rankings가 잘못된 leftover 관계를 표시합니다."closest"와"farthest"만 매핑하고, 그 외 값은 배지와 accessible caption에서 제외하세요.🤖 Prompt for AI Agents