Skip to content

feat: show Valkey activity outbox fail-closed (v0.85.0) - #229

Open
seonghobae wants to merge 1 commit into
mainfrom
feat/valkey-activity-outbox-fail-closed-v0850
Open

feat: show Valkey activity outbox fail-closed (v0.85.0)#229
seonghobae wants to merge 1 commit into
mainfrom
feat/valkey-activity-outbox-fail-closed-v0850

Conversation

@seonghobae

Copy link
Copy Markdown
Contributor

Buyer impact

After login, Outbox sits between Rankings and Calendar. When Valkey is disabled or does not answer, Demo Analyst sees Outbox · Valkey not available. When the port accepts, delivered ticket events are listed by summary. Click opens that post. A hidden post is omitted. Never invent a stream id or a theta.

  • Ticket create / status change / commitment-derive persist activity_outbox_event as outbox_pending first, then XADD onto activity:{post_id}, then mark outbox_delivered with the Valkey entry id (Hohpe & Woolf 2003; Kleppmann 2017).
  • ValkeyOutboxClient default ping raises ValkeyNotAvailable. VALKEY_DISABLED=1 keeps the fail-closed ping.
  • GET /api/outbox is post_read and returns unavailable + empty deliveries when the port is down.
  • Idempotency is (post_id, event_type_code, event_summary). make seed writes the pending row, XADDs, then marks delivered so home Outbox is not empty after a fresh stack.
  • Tests: default/disabled fail-closed, accepted delivery, hidden post omitted, pending/missing-id dropped, invented stream id dropped, frontend unavailable/accepted click.
  • ADR 0026 + CHANGELOG 0.85.0 + ARCHITECTURE / AGENTS. Distinct from TEPP outbox on feat: submit TEPP runs through a fail-closed HTTP port (v0.79.0) #214 (ADR 0022 / 0023).

Exact head

0b0c9d8 on feat/valkey-activity-outbox-fail-closed-v0850.

Base: main @ 8c020aa (merged #220 RankWeave).

Review gate

Not in this slice

Leftover pairs landed as #211. RankWeave landed as #220. TEPP fail-closed HTTP is #214. naruon mailbox is #217. ThreadWeave conversations are #219. Keyverse IdP is #221. Orchestrator envelope is #228. Storybook increment is #123/#192.

After login, Outbox names valkey_not_available when the port is
down and lists accepted ticket deliveries when Valkey answered.
A hidden post is omitted. Never invent a stream id or a theta.
Independent exact-head APPROVE required. Do not mix into #74 or #92.
@cursor

cursor Bot commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@coderabbitai

coderabbitai Bot commented Aug 17, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 41 minutes

Limit details: You’ve used all 1 included review currently available under your plan.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 4e9ac833-6ffd-4291-b699-59b3e9d61345

📥 Commits

Reviewing files that changed from the base of the PR and between 8c020aa and 0b0c9d8.

⛔ Files ignored due to path filters (1)
  • uv.lock is excluded by !**/*.lock
📒 Files selected for processing (25)
  • .env.example
  • AGENTS.md
  • ARCHITECTURE.md
  • CHANGELOG.d/0.85.0-valkey-activity-outbox.md
  • CHANGELOG.md
  • README.md
  • backend/app/config.py
  • backend/app/main.py
  • backend/app/outbox_ingestion.py
  • backend/tests/test_api.py
  • backend/tests/test_config.py
  • docker/postgres-init/Dockerfile
  • docs/adr/0026-valkey-activity-outbox.md
  • docs/lineage-bi-research-notes.md
  • frontend/package.json
  • frontend/src/App.test.tsx
  • frontend/src/App.tsx
  • frontend/src/api.ts
  • lineageweave/__init__.py
  • lineageweave/valkey_outbox.py
  • migrations/0013_activity_outbox.sql
  • pyproject.toml
  • scripts/seed_demo_data.py
  • tests/test_activity_outbox_schema.py
  • tests/test_valkey_outbox.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Contributor Author

Exact head 0b0c9d8 on feat/valkey-activity-outbox-fail-closed-v0850.

Buyer: after login, Outbox · Valkey not available when the port is down. Accepted deliveries list the summary; click opens that post. Hidden posts omitted. Never invent a stream id or a theta.

Independent exact-head APPROVE required before squash. This comment is not an approval. Do not mix into #74 or #92. Do not self-approve. Owner/self COMMENT is not APPROVE.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant