feat(ui): distinguish plural affiliations on related-node chips (v0.76.0) - #120
Closed
cursor[bot] wants to merge 8 commits into
Closed
feat(ui): distinguish plural affiliations on related-node chips (v0.76.0)#120cursor[bot] wants to merge 8 commits into
cursor[bot] wants to merge 8 commits into
Conversation
…2.0) Related chips still said "Ada West (Person)" even though the payload already had person_side_code. Attach person_side_label from common_lookup_value and use that caption (and accessible name) so the buyer sees Our side / Counterparty, not the ontology class.
Buyer gap: after person chips used Our side / Counterparty, org chips still said Demo Corp (Organization). Hydrate entity_level_label from common_lookup_value so the walk reads Demo Corp (Company). Missing lookups fall back to the code. Never invents a level.
Buyer gap: person chips say Our side / Counterparty and org chips say Company, but post chips still appended (Post). The related walk now shows the post title only.
Related person chips use the primary affiliation organization when one exists. After make seed, Ada West walks to Priya Nair, Northridge Grid (Counterparty) and Demo Corp walks to Ada West, Demo Corp (Our side). Missing affiliations stay omitted.
Resolved corporate_entity rows collapse aliases into entity_name. Distinct unresolved orgs stay omitted so the chip never invents a primary. Seeded Priya stays side-only.
Related-node chips now mark a known-plural affiliation set as affiliation_ambiguous and caption it "multiple organizations" so the buyer opens the Keyman panel. Unique catalog identity still shows entity_name; casefold aliases collapse; a guessed primary is never invented. Co-authored-by: Seongho Bae <[email protected]>
3 tasks
3 tasks
5 tasks
This was referenced Aug 16, 2026
Contributor
|
Draft duplicate of #123 (v0.76 plural affiliation chips). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Buyer gap: after #92's unique-identity rule, a known-plural affiliation set still looked like a person with no organization. The buyer could not tell to open the Keyman panel.
This head is #92 (
15de5d4) plus v0.76.0:entity_name; aliases collapse; a guessed primary is never invented.affiliation_ambiguousand the captionPriya Nair, multiple organizations (Counterparty)aftermake seed.Prefer this head over merging #92 alone when both the identity rule and the missing-vs-plural signal should land together. #112 / #113 are obsolete caption repairs of the old
c72317cchead.Verified locally: 8 affiliation unit tests passed; 42 frontend tests passed; oxlint clean.
Do not merge until exact-head Checks are terminal-success. Do not merge before or in parallel with a conflicting rewrite of the same caption contract.