feat: apply analysis-run knowledge cutoff to visible posts (v0.83.0) - #108
Closed
cursor[bot] wants to merge 22 commits into
Closed
Conversation
The fail-closed rollback script starts an explicit transaction. On an autocommit connection a RAISE left that transaction aborted, so the empty-registry cleanup could not run.
Buyer gap: after #95 the home Analysis runs row was inert text. Clicking the seeded Demo Corp lineage run now loads GET /api/analysis-runs/{id} and shows cutoff, requested date, and document count. Hidden runs stay not-visible. Synthetic aggregates only -- never a DSN or source SQL.
Buyer gap: after #100 the detail showed cutoff and counts but not the legal lifecycle the registry already stored. GET /api/analysis-runs/{id} now returns labeled status_history (Pending → Running → Succeeded with occurrence times). The list stays latest-status only. Hidden runs still 404 and never leak events. Failure codes stay machine tokens. Synthetic Demo Corp seed only.
Buyer gap: after #102 the run detail showed history but no way to open a post. Detail now lists ABAC-visible titles in the run's scope. Other-corp private posts stay hidden. List payloads stay aggregates-only. Synthetic titles only.
PR #91 landed an adaptive-orchestration ADR 0013 on the #74 base after this slice already used 0013 for the normalized analysis-run registry. Renumber the adaptive record to 0015 so ADR numbers stay unique. Co-authored-by: Seongho Bae <[email protected]>
The #74 changelog fold still called that decision ADR 0013. This stack keeps the analysis-run registry as ADR 0013, so the adaptive record is 0015. Co-authored-by: Seongho Bae <[email protected]>
A later own-corp post no longer appears inside a historical run. Detail shows revision and configuration digest prefixes so an operator can confirm the run they approved. AnalysisRunsPanel is extracted for the Storybook inventory. Co-authored-by: Seongho Bae <[email protected]>
Contributor
|
Review: this draft is the right v0.83.0 buyer slice (cutoff-scoped posts + digest prefixes +
PR #110 ( |
Contributor
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Buyer impact
Open an analysis run and you now see only posts that existed at that run's knowledge cutoff. A later own-corp post no longer appears inside a historical reconstruction. The detail also shows revision and configuration digest prefixes so you can confirm the run matches the code you approved. If the list is empty, open a later run or ask an administrator to capture a newer snapshot.
What changed
GET /api/analysis-runs/{id}appliessource_post.created_at <= knowledge_cutoffon top of the existing ABAC scope filter (ADR 0016).Revision/Configprefixes fromcode_revision_shaandconfiguration_sha256.AnalysisRunsPanelis extracted fromApp.tsxand inventoried for Storybook.backend/tests/test_api.py(self-skips without a live DSN).Stack
Draft-stacked on PR #89 / #74 (
feat/role-responsibility-agent-ontology). Includes the #89 registry commits plus this v0.83.0 slice. Do not merge before #74 reaches protectedmainand #89's exact-head evidence is regenerated.Refs #79.