fix(strix): include backend app dependency context - #1191
Conversation
|
Warning Review limit reached
Next review available in: 54 minutes Limit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?Wait for the limit to reset, then comment An organization admin can change what happens after included review limits in Billing. How do review limits work?CodeRabbit enforces per-developer PR review limits within each organization. For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Addressed the current-head review finding in commit
Local evidence: |
|
Current-head review completed at |
|
Closing as a duplicate writer after absorbing the verified repair into the canonical Strix owner PR #1153 at exact commit The canonical implementation preserves this PR's exact-head |
Summary
backend/app/*.pyas trusted context when a PR changes a Python module in that packageknowledge_graph.pyimporting an unchangedpost_eligibility.pyRoot cause
The Strix PR scope contained changed files only. The central context list covered a different
backend/apilayout, sobackend.app.post_eligibilitywas absent from the scanner input even though it existed in the PR head and base repository. Strix then reported a false MEDIUM missing-module finding. The same run also recorded NVIDIA NIM rate limits; this change does not neutralize provider failures or vulnerability findings.Security boundary
The scanner still executes trusted central code. PR-head blobs are copied as non-executable data. The context package is not a changed-file finding boundary: only the original changed-file list is used for attribution. No credentials or untrusted workflow code are executed.
Verification
bash -n scripts/ci/strix_quick_gate.sh scripts/ci/test_strix_quick_gate.shpython3 -m unittest tests.test_strix_changed_path_policy tests.test_strix_nvidia_nim_not_found_fallback-> 14 passedbackend/app/knowledge_graph.pyand unchanged local import -> exit 0git diff --check