Skip to content

fix(strix): include Rust workspace context for CI scans - #1173

Closed
seonghobae wants to merge 2 commits into
mainfrom
fix/strix-rust-workspace-context
Closed

fix(strix): include Rust workspace context for CI scans#1173
seonghobae wants to merge 2 commits into
mainfrom
fix/strix-rust-workspace-context

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Treat Rust source files and Cargo manifests/lockfiles as Strix-supported PR scope.
  • When workflow or CI files change in a Rust workspace, include Cargo, toolchain, and deny.toml context so dependency analysis is complete.
  • Add regression assertions and changelog evidence.

Verification

  • git diff --check
  • bash -n scripts/ci/strix_quick_gate.sh scripts/ci/test_strix_quick_gate.sh
  • static Strix scope regression assertions pass before the PR self-test reached unrelated legacy fixture failures.

This fixes the root repository boundary for TEPP PR #154's Strix incomplete-scan failure; no TEPP-local workaround is required.


Open in Devin Review

@coderabbitai

coderabbitai Bot commented Aug 20, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 7 minutes

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

Wait for the limit to reset, then comment @coderabbitai review or push new commits to the PR.

An organization admin can change what happens after included review limits in Billing.

How do review limits work?

CodeRabbit enforces per-developer PR review limits within each organization.

For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 46d73a12-337f-4149-88e8-e0658ceeabc3

📥 Commits

Reviewing files that changed from the base of the PR and between 55a8b57 and eceb30a.

📒 Files selected for processing (3)
  • CHANGELOG.md
  • scripts/ci/strix_quick_gate.sh
  • scripts/ci/test_strix_quick_gate.sh

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

@seonghobae

Copy link
Copy Markdown
Contributor Author

Exact-head update for central PR #1173 at a676436: exact-head-policy and exact-head-path-policy are SUCCESS. The Rust scope change is limited to Strix source classification, Cargo manifest recognition, and Rust workspace context for workflow/CI scans; TEPP PR #154 remains queued for the central repair before its Strix result can be revalidated.

@seonghobae

Copy link
Copy Markdown
Contributor Author

@opencode-agent Please review exact current HEAD a6764368c634e9ea3a49d162a560d771d518e37e only. Focus on Rust workspace context selection in scripts/ci/strix_quick_gate.sh and its shell-contract coverage. Evidence: bash scripts/ci/test_strix_quick_gate.sh is running against this exact head; bash -n scripts/ci/strix_quick_gate.sh scripts/ci/test_strix_quick_gate.sh passed; shellcheck passed; git diff --check passed. Do not reuse predecessor conclusions; report actionable findings or approve only this exact commit.

@seonghobae

Copy link
Copy Markdown
Contributor Author

@opencode-agent Please review current HEAD a676436 for PR #1173. Re-evaluate the Rust workspace context changes for Strix and the complete current diff against exact-head policy.

@seonghobae

Copy link
Copy Markdown
Contributor Author

@opencode-agent review exact current HEAD a676436. Inspect the complete diff, validate security and regression behavior, and publish only evidence bound to this SHA. Do not transfer predecessor approval, modify the branch, or merge.

Copy link
Copy Markdown
Contributor Author

Current-head review

Reviewed exact head a6764368c634e9ea3a49d162a560d771d518e37e:

  • Rust .rs, Cargo.toml, and Cargo.lock are included in supported scope.
  • Rust workspace context is added only when the root Cargo manifest exists, covering toolchain and deny.toml policy inputs.
  • The shell changes preserve the existing deployment-context path and the regression assertions cover each new boundary.
  • Live checks: all 10 listed workflows are terminal-success; review threads: 0; qualifying independent approval: absent.

No source correction is required at this head. Protected merge remains gated by the missing independent approval.

Copy link
Copy Markdown
Contributor Author

Current-head refresh completed at eceb30ab7b0002254d618c81e47d04a63b6c24fe.

  • Merged protected main@55a8b576725451dfe0a21a57d36a2f1a41619b24 normally; no source conflict or semantic delta was introduced.
  • Revalidated Rust workspace scope: bash -n, Strix quick-gate self-test in progress locally, compileall, and git diff --check.
  • The PR remains mergeable with zero unresolved threads and no independent approval. Hosted Checks are running on this exact head; merge remains governed by terminal Checks and protected review approval.

Copy link
Copy Markdown
Contributor Author

Current-head review complete at eceb30ab7b0002254d618c81e47d04a63b6c24fe (base 55a8b576725451dfe0a21a57d36a2f1a41619b24). The Rust scope change is narrow: .rs, Cargo manifests/lockfiles, toolchain and deny policy are included for workflow scans when the target has a root Cargo workspace; existing fail-closed path handling is unchanged. Static Strix contract checks and shell syntax passed; the full local harness reached an unrelated host OSError: [Errno 28] No space left on device while writing its temporary normalizer fixture, so hosted Checks remain authoritative. Current hosted runs show no failure, with Python Security and CodeQL still queued. No inline threads; please obtain an independent non-author approval on this exact head and wait for all protected Checks before merge.

Copy link
Copy Markdown
Contributor Author

Closing as absorbed into the canonical Strix owner PR #1153 at exact head 035343c8a68e880a4abf27f7c947bfed9dbaafcf.

The canonical head preserves this PR's Rust source/Cargo manifest classification and root-workspace Cargo/toolchain/deny.toml context, and strengthens the evidence from static string assertions to a behavioral workflow-scope fixture. RED proved the materialized scan target omitted Cargo.toml, Cargo.lock, rust-toolchain.toml, and deny.toml; GREEN requires all four with trusted content while Rust source and manifests remain governed changed inputs.

Canonical verification: filtered behavioral GREEN; full test_strix_quick_gate: PASS; focused Strix contracts 29 passed, 16 subtests; full central suite 1,288 passed, 16 subtests; shell syntax, compilation, diff checks pass. The four remote blobs and tree 61b979fc475adf85e750961167c6ae027aeef292 match the verified local tree. Retaining this PR would leave a competing writer on the same Strix gate/test source.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant