fix(strix): classify ModelBehaviorError flake with zero findings - #1091
fix(strix): classify ModelBehaviorError flake with zero findings#1091seonghobae wants to merge 1 commit into
Conversation
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
|
@cwl-noema-review Independently review exact head |
|
Warning Review limit reached
Next review available in: 4 minutes Limit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits within each organization. For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Exact head |
|
Cycle 2026-08-17T20:16 KST: exact head |
|
Cycle 2026-08-17T20:35 KST. Exact head Classifier treats same-line trusted SDK Independent exact-head APPROVE required. This comment is not an approval. Do not self-approve. Owner/self COMMENT is not APPROVE. |
|
Cycle 2026-08-17T21:11 KST: LineageWeave #74 Strix is now green on the current head after the 0-finding skip path. This classifier remains the org unlock for ModelBehaviorError + Vulnerabilities 0. Do not weaken fail-closed on |
|
Cycle 2026-08-17T22:00 KST: ModelBehaviorError classifier is the org unlock for LineageWeave Strix fail-closed flake (Vulnerabilities 0). Do not weaken fail-closed on |
|
BandScope downstream acceptance constraint from current required-check evidence: do not make Please preserve fail-closed required-check semantics: classify this as infrastructure for retry/fallback routing, but the final required |
Treat pydantic-ai or LiteLLM ModelBehaviorError plus Vulnerabilities 0 as backend unavailability. Vulnerabilities [1-9] stay fail-closed. A source-file mention without the SDK exception prefix is not infra.
a3c16ce to
f188ba3
Compare
|
Rebased onto current main |
|
Superseded by #1138, the current-main successor for the same Strix |
Pull request was closed
Why
Strix can exit fail-closed on
pydantic_ai.exceptions.ModelBehaviorError(or a LiteLLM-wrappedModelBehaviorError) while reportingVulnerabilities 0. That is backend flake, not a product finding.Decision
ModelBehaviorErroris infrastructure.Vulnerabilities [1-9]orseverity:marker is present.ModelBehaviorErrortext is not classified.Vulnerabilities [1-9]stays fail-closed.Exact head:
a3c16ce. Do not weaken fail-closed on real findings. Independent exact-head APPROVE required. Do not self-approve.Verification
python3 -m unittest tests.test_strix_modelbehaviorerror_classifier tests.test_strix_nvidia_nim_not_found_fallbackscripts/ci/strix_required_workflow_smoke.sh