fix(scheduler): ignore manual Strix dispatch as merge evidence - #1061
Draft
cursor[bot] wants to merge 1 commit into
Draft
fix(scheduler): ignore manual Strix dispatch as merge evidence#1061cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
A caller-selected workflow_dispatch Deep run can publish the same Strix check name for up to six hours. Keep required evidence on pull_request_target and repository_dispatch strix-scan so a manual scan cannot park, fail, or satisfy merge. Co-authored-by: Seongho Bae <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A caller-selected
workflow_dispatchDeep run can publish the same Strix check name for up to six hours. Required merge evidence stayspull_request_targetandrepository_dispatchstrix-scan.What to do next
Review this slice on its own. Do not fold it into #1054 (official
quick|standard|deepmapping). After this lands, a manual Deep scan on a PR head will not park, fail, or satisfy the merge scheduler.Keep #1054 as the only mode-mapping vehicle. After exact-head quality is green there, add the doctoring residual-risk sentences on that branch.
Change
checkSuite.workflowRun.eventand ignoreworkflow_dispatchcheck runs in Strix merge evidence, failed-check collection, action-required, and job reruns.strixcommit status.active_review_run_refsskips same-head Deep runs so they cannot returnalready_runningand blockstrix-scan.strixcommit status can still supersede a failed required check.Doctoring:
docs/doctoring/strix-manual-dispatch-not-merge-evidence.md(APA 7th).Local evidence:
pytest tests/test_pr_review_merge_scheduler.py tests/test_required_workflow_queue_contract.py— 161 passed; interrogate 100% on the scheduler module.