Skip to content

docs(parity): corrections round 8, 7 rows re-read against their issues - #1145

Merged
rubenvdlinde merged 1 commit into
developmentfrom
parity/corrections-8
Sep 28, 2026
Merged

rubenvdlinde merged 1 commit into
developmentfrom
parity/corrections-8

Conversation

@rubenvdlinde

Copy link
Copy Markdown
Contributor

Corrections round 8 re-reads seven stackiq matrix rows against the issues the OpenSpec issues lanes filed or commented on 27 and 28 September, at the development tip d22033a. Only openspec/parity/capabilities.json changes. Every row keeps its rating: each issue shows a real defect at the tip, but none of them stops the capability the row rates, so each row gains one evidence sentence in built.evidence that cites the issue and file:line, and one sentence in note that says why the rating stands. evidence.stackiq, the competitor cells, built.state and the other rows are untouched.

row before after issue what the issue shows at d22033a
ins-faceted-search partial partial (evidence and note) stackiq#1141 the domain facet is always empty: lib/Service/FacetService.php:704 reads domain, the element schema declares domein (lib/Settings/softwarecatalogus_register.json:4642)
mkt-find-software yes yes (evidence and note) stackiq#1141 same domain defect; this row filters on reference component and standard, which work
org-roles partial partial (evidence and note) stackiq#1137 the role group by organisation type fires only for Community: lib/Service/Stackiq/ContactPersonHandler.php:1625 maps Dutch keys, organization.type is English (register :2309)
org-merge partial partial (evidence and note) stackiq#1086 four more references stay on the source: usage.provider, organization.deelnames and participants, model.organizations (register :2693, :2200, :2236, :6027)
org-merge-dry-run yes yes (evidence and note) stackiq#1086 the dry run uses the same lists (lib/Service/MergeOrganisatieService.php:172), so it omits what the merge leaves behind, but it matches what the merge changes
ops-scheduled-sync partial partial (evidence and note) stackiq#1139 the enable switch is never read: lib/BackgroundJob/OrganizationContactSyncJob.php:99 runs regardless
ins-progress partial partial (evidence and note) stackiq#1138 progress lives only in the starting user's session (lib/Service/ProgressTracker.php:83, :412, :332), so no other login or cron job can read it

Rows on the list left alone: none. Every cited file:line held at d22033a; the only commit since the ledger tip a0afae7 is the parity-only #1143.

Checks:

  • parity-verify --strict: 175 rated rows, 40 pending, 6 systems, one finding (the unknown-cells census, 469 cells), schema errors 0; the before and after outputs are identical.
  • checks.sh with node v24.11.1 and npm 11.19.1, run on the edited working tree: npm ci exit 0, lint exit 0, format exit 0, check:manifest exit 0, check:schema-l10n exit 0, test:l10n exit 0.
  • composer check:strict: not run, no lane has a bare-clone run that finishes, and this PR changes only the matrix JSON, which no PHP gate reads.

🤖 Generated with Claude Code

@rubenvdlinde
rubenvdlinde merged commit 7ca2cc0 into development Sep 28, 2026
36 of 37 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

Quality Report — ConductionNL/stackiq @ 726d15b

Check PHP Vue Security License Tests
lint ✅
phpcs ✅
phpmd ✅
psalm ✅
phpstan ✅
phpmetrics ✅
eslint ✅
stylelint ✅
build ✅
check-manifest ✅
check-vue-demi ✅
test-l10n ✅
format ✅
check-schema-l10n ✅
check-l10n-js ✅
composer ✅ ✅ 130/130
npm ✅ ✅ 807/807
app:check-code ⏭️
info.xml ✅
REUSE ❌
lockfile sync ✅
PHPUnit ⏭️ not run for this diff — no file in this diff matches the code globs, and none carries a source extension — the heavy tier has nothing to decide about it.
Newman ⏭️
Playwright ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it on any branch from the Actions tab, or locally with npx playwright test.
Hydra gates ❌

Quality workflow — 2026-09-28 05:02 UTC

Download the full PDF report from the workflow artifacts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant