docs(openspec): OpenSpec pass batch 2, architecture and lifecycle changes - #1109
Merged
Merged
Conversation
…s on CnGraphCanvas
…raft a marked view for review
…ked to applications in use
… GGM entities on applications in use
…laps and a coverage map per organisation
…d risk scores behind the TIME class
…ce windows, owner notices and a product roadmap
…ed scenarios compared with today
… stackiq objects linked to applications
… that runs without RBAC
…kiq and office files through filinq
…ites nothing replaces the broken round trip
…nto parity/openspec-pass-2
…o parity/openspec-pass-2
Contributor
Quality Report — ConductionNL/stackiq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| check-vue-demi | ✅ | ||||
| test-l10n | ✅ | ||||
| format | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| check-l10n-js | ✅ | ||||
| composer | ✅ | ✅ 130/130 | |||
| npm | ✅ | ✅ 807/807 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ⏭️ not run for this diff — no file in this diff matches the code globs, and none carries a source extension — the heavy tier has nothing to decide about it. | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it on any branch from the Actions tab, or locally with npx playwright test. |
||||
| Hydra gates | ❌ |
Quality workflow — 2026-09-27 18:34 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenSpec pass for stackiq, batch 2 of 3: 11 changes for architecture and lifecycle, 19 matrix rows. Specs only, nothing is implemented. The decisions for every row, the reading of the rule and the defects found are in batch 1 (#1094); this batch adds its build rows to
openspec/parity/gap-decisions.jsonand sets them tospecifiedin the matrix.Changes in this batch
architecture-views-editor:arch-modelling,arch-diagram-version-compare,arch-view-tagsarchitecture-assistant-drafted-views:arch-ai-diagramarchitecture-process-mapping:arch-process-mapping,arch-process-step-fieldsarchitecture-data-model-and-ggm:arch-data-model,arch-ggm-linkarchitecture-reference-component-coverage:arch-capability-map,arch-gap-analysis,life-overlap,life-rationalisation-reportarchitecture-future-state-scenarios:arch-scenariosarchitecture-decision-register:arch-decision-registerarchitecture-views-to-office-documents:arch-views-officearchitecture-round-trip-check:arch-round-triplifecycle-application-value-assessment:life-value-assessmentlifecycle-maintenance-and-supplier-roadmap:life-maintenance-window,mkt-supplier-roadmapRows below the bar that ride with a build row of the same change:
life-rationalisation-report(withlife-overlap),mkt-supplier-roadmap(withlife-maintenance-window).life-maintenance-windowwas marked specified with no change directory;lifecycle-maintenance-and-supplier-roadmapis that change.Matrix edits in this batch
specified, each note naming its change directory.gap-decisions.jsongains their 19 build entries (103 in all).Defects found while reading the code
Written into the change that touches each, not filed as issues:
GET /api/views/{viewId}reads a view throughViewService::getViewFromRegister()(lib/Service/ViewService.php:307) with_rbac: falseand_multitenancy: false(:328), so it returns any view to any signed-in user. Once organisations draw their own views that would expose another organisation's view by uuid;architecture-views-editoranswers 404 for a view that is not imported or unmarked.POST /api/archimate/test-round-trip,lib/Controller/SettingsController.php:2886) is@NoAdminRequiredand imports a test model into the live shared register; its comparison can never succeed.architecture-round-trip-checkreplaces it with an admin check that writes nothing.FacetServicereadselement['domain']while the schema declaresdomein, so the domain facet stays empty (inherited, not in this batch's scope).moduleVersionlifecycle names Dutch states no row holds;lifecycle-maintenance-and-supplier-roadmapmoves it onto the enum values with a schema version bump.Checks
openspec validate: every change of this batch is valid with--strict.openspec validate --changes: 40 passed, 3 failed (the three failures are the pre-existingadopt-apphost,beta-surface-alignmentandrename-app-id-to-stackiq).parity_verify.py --strict: only the unknown-cells census (469 cells, as after batch 1), no other finding, no schema error.composer check:strict(private HOME and TMPDIR): exit 0 (lint, phpcs, phpmd, psalm and phpstan pass;test:allprints SKIPPED because it needs a Nextcloud server tree).npm run lint: exit 0 (217 warnings, 0 errors, none in files this PR touches).openspec/: its change directories,openspec/parity/capabilities.jsonandopenspec/parity/gap-decisions.json.🤖 Generated with Claude Code