Skip to content

The email template editor says a template was saved when nothing was saved #1082

Description

@rubenvdlinde

What goes wrong

The Save button in the email template editor (admin settings, Email, Templates tab) does not save anything and still shows a success message. The backend endpoints that would load and save templates exist but the settings page never calls them.

Evidence, re-read at c9760e0

  • src/views/settings/sections/EmailConfiguration.vue:405 binds the Save button to saveTemplate() (:902). The method makes no request. It logs "Template save functionality is not yet implemented in the backend" (:908-910), sets templateSaveResult to success: true with "Template saved locally (backend implementation pending)" (:911-915), and calls showSuccess (:916-918). There is no local persistence either.
  • resetTemplate() (:881-894) is the same shape: no request, a success toast.
  • loadTemplates() (:784-795) sets this.templates = {} with the same "not yet implemented" log, so the editor never receives the stored templates.
  • The backend does support this: appinfo/routes.php:78-82 routes GET /api/email/templates, GET and POST /api/email/templates/{templateName}, .../default and .../variables, and lib/Controller/SettingsController.php:2194 updateEmailTemplate() writes email_template_{name} to app config. Nothing in src/ calls any api/email/templates path.
  • The templates are used for real outbound mail: lib/Service/SymfonyEmailService.php:466 (registration), :553 (activation) and :641 (user creation).

Why it matters

An admin who edits the registration or activation mail and presses Save is told it worked, and every user keeps receiving the old text.

Needs a live check

Code reading. Because loadTemplates() leaves the list empty, confirm on a live instance whether the editor and its Save button are reachable at all; the success-without-save path holds whenever they are.

Surfaced by the capability matrix in stackiq#1072 (merge 38b9938), row org-activation-mail.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

triageAwaiting triage

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions