Skip to content

Clicking a row on the applications, suites or vulnerabilities list does not open its detail page #1081

Description

@rubenvdlinde

What goes wrong

Three detail pages cannot be opened from their own list. Clicking an application on the Applications list, a suite on the Suites list, or a vulnerability on the Vulnerabilities list does not open ModuleDetail, SuiteDetail or KwetsbaarheidDetail.

Evidence, re-read at c9760e0

Applications (ModuleDetail, src/manifest.json:491):

  • The Modules page (src/manifest.json:592, route /modules) is FacetedCatalogIndexView. At src/views/FacetedCatalogIndexView.vue:108-117 it renders a standalone CnIndexPage with no @view, @row-click or rowClickToView binding.
  • In @conduction/nextcloud-vue 2.55.1 (the version locked in package-lock.json), CnIndexPage has selectable default true (CnIndexPage.vue:1283-1286). onRowClick (:5190-5194) toggles selection and returns when selectable && !rowClickToView, and the row action View only emits view (:5427-5429), which nothing listens to here. So both gestures are inert.
  • The only link to ModuleDetail in the app is the Applications list on OrganisatieDetail (src/manifest.json:417). The Services page (:647) uses the same component and has the same shape.

Suites (SuiteDetail, src/manifest.json:674):

  • src/views/suites/SuitesIndexView.vue:21-35 binds @rowClick="onRowOpen" (navigation at :88-89) but does not set rowClickToView or selectable: false. With the library defaults above, a row click toggles selection and row-click is never emitted.
  • SuiteDetail is reached only right after creating a suite with the wizard (onSuiteCreated, :101-106).

Vulnerabilities (KwetsbaarheidDetail, src/manifest.json:977):

  • The list page (src/manifest.json:973, KwetsbaarhedenView) opens rows with openDetail(row) (src/views/KwetsbaarhedenView.vue:94). At :417-423 that sets the active object and calls navigationStore.setModal('vulnerability'), which src/modals/Modals.vue:14-16,44 renders as the generic ObjectModal, the edit form. Its docblock says it opens "the full vulnerability record". Nothing in src/ routes to KwetsbaarheidDetail.

Why it matters

The detail pages carry the related data (versions, compliance, exposure, audit trail) that the lists do not, and users cannot reach them from the obvious place, so those features look missing.

Needs a live check

Code reading of both repos. Confirm by clicking a row on /modules, /suites and the vulnerabilities page.

Surfaced by the capability matrix in stackiq#1072 (merge 38b9938), rows land-register-application, land-detail-page, land-suite, sec-vulnerability-page and sec-exposure.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

triageAwaiting triage

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions