Skip to content

Application and suite detail pages show blank descriptions because they ask for renamed properties #1080

Description

@rubenvdlinde

What goes wrong

Four places in the manifest ask for property names the schemas no longer have, so the application detail page, the suite detail page and the BIO measures list show empty fields or empty columns where the description, contact person, BBN level and BIO measure should be.

Evidence, re-read at c9760e0

Schema properties are read from lib/Settings/softwarecatalogus_register.json.

  • ModuleDetail data widget md-data, src/manifest.json:500: include lists beschrijvingKort, beschrijvingLang and contactpersoon. The module schema has shortDescription, longDescription and contactPerson, and none of the three Dutch keys.
  • SuiteDetail data widget suite-data, src/manifest.json:683: include lists the same beschrijvingKort, beschrijvingLang, contactpersoon. The suite schema has shortDescription, longDescription, contactPerson.
  • BioMaatregelen index, src/manifest.json:755-767 (schema bioMeasure): column bbnNiveau. The bioMeasure schema has bbnLevel.
  • ModuleDetail compliance list md-compliance, src/manifest.json:503 (schema compliancy): column bioMaatregel. The compliancy schema has bioMeasure.

The same md-data widget already uses the renamed bbnLevel, so the rename was applied partly.

Why it matters

The short and long description are the main text of an application and a suite, and they appear blank on the pages meant to show them, which makes a filled-in record look empty.

Needs a live check

Code reading. How the library renders an include key that is not in the schema (hidden, or an empty row) should be confirmed on a live ModuleDetail page.

Surfaced by the capability matrix in stackiq#1072 (merge 38b9938), rows land-detail-page, land-suite, mkt-contacts-per-product, comp-bio-measures and comp-bio-assessment. Related but separate: #492 (the database column rename).

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

triageAwaiting triage

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions