Skip to content

The concept organisations widget is always empty, and no screen can change an organisation's status #1078

Description

@rubenvdlinde

What goes wrong

The "Concept organisaties" dashboard widget always shows an empty list, and its accept button would write a status that is not allowed. Beyond the widget, there is no working way in the app to move an organisation between Draft, Active and Inactive.

Evidence, re-read at c9760e0

Widget:

  • lib/Dashboard/ConceptOrganisatiesWidget.php is registered at lib/AppInfo/Application.php:760 and loads the conceptOrganisatiesWidget bundle (:103).
  • src/views/widgets/ConceptOrganisatiesWidget.vue:100 keeps only organisations where item.status?.toLowerCase() === 'concept'.
  • organization.status in lib/Settings/softwarecatalogus_register.json:2317 (enum at :2346) allows Draft, Active, Inactive, merged, default Draft. lib/Repair/RenameDutchCatalogValues.php:76 renamed stored Concept values to Draft. So no organisation matches and the list is always empty.
  • onAccept at :126-129 patches status: 'actief', which is not in the enum.

No other status path:

  • status is visible: false in the schema (:2322), so it does not appear on the organisation form.
  • OrganisatieDetail's data widget (src/manifest.json:412) includes status with overrides: { status: { editable: false } }.
  • src/modals/object/ChangeOrganisatieStatusDialog.vue is mounted by src/dialogs/Dialogs.vue:6-7 when navigationStore.dialog === 'changeOrganisatieStatus', but nothing in src/ sets that dialog, so it never opens.
  • The Organisations index (src/manifest.json, page with filter: { status: [Draft, Active, Inactive] }) can only filter on status.

Why it matters

Status decides whether VNG has approved an organisation for the catalogue (the property description says so), and it also drives public visibility (the organisation read rule matches status: Active, see #1074). An admin reviewing new organisations sees an empty queue and has no screen to approve one.

Needs a live check

Code reading. Confirm on a live dashboard with at least one organisation in Draft.

Line numbers differ slightly from the matrix evidence (enum at :2346 not :2321, detail override at src/manifest.json:412 not :403); the substance holds.

Surfaced by the capability matrix in stackiq#1072 (merge 38b9938), rows ins-concept-orgs-widget and org-status.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

triageAwaiting triage

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions