fix(e2e): refresh the roadmap baseline and vendor a hydra-gates that ships the skip check - #193
Merged
Merged
Conversation
…ships the skip check The two remaining E2E reds on development, both found by a manual run of Code Quality (36438054845), the only way to reach Playwright outside the promotion path. - FeaturesRoadmap-chromium-linux.png is CI's own render from that run. The page gained the Store and Reports footer entries (#192), and the right-hand panel reflows under nextcloud-vue 2.57. Both attempts rendered byte-identical images. - conduction/hydra-gates ^1.0 locked v1.9.0, which predates check_e2e_skips.py (added 2026-08-24), so the skip-discipline step failed with 'not found'. ^1.18.0 ships it.
rubenvdlinde
requested review from
Rem-Dam,
SudoThijn,
WilcoLouwerse,
bbrands02,
remko48 and
rjzondervan
as code owners
September 28, 2026 15:16
Contributor
Quality Report — ConductionNL/nextcloud-app-template @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-specs | ✅ | ||||
| check-manifest | ✅ | ||||
| format | ✅ | ||||
| composer | ✅ | ✅ 103/103 | |||
| npm | ✅ | ✅ 857/857 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ✅ | ||||
| Newman | ✅ | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it on any branch from the Actions tab, or locally with npx playwright test. |
||||
| Hydra gates | ✅ |
Quality workflow — 2026-09-28 15:43 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
After #192, a manual Code Quality run (36438054845) reached Playwright: 10 passed, 1 failed. Before #192,
developmentfailed 7. Playwright only runs on promotions tobeta/mainor by hand, so this is the first time the suite has been seen since. Two reds were left, and both predate #192.What changed
FeaturesRoadmap-chromium-linux.pngis replaced with CI's own render from that run. The screenshot covers#content, navigation included, so the Store and Reports footer entries show up in it, and the right-hand panel reflows under nextcloud-vue 2.57. I checked the image: the page is intact and the footer order is Documentation, Store, Reports, Features & roadmap. Both attempts in the run were byte-identical.^1.0locked v1.9.0, which predatescheck_e2e_skips.py(added 2026-08-24), so the E2E skip-discipline step failed with "not found". Now^1.18.0, which ships it at the vendored path the workflow checks first.Verified
composer check:strict: lint, phpcs, phpmd, psalm and phpstan pass. Its PHPUnit leg cannot boot outside a Nextcloud server tree (OC_Appnot found). The unit suite (phpunit-unit.xml) passes 30 of 30, and the server-backed suites were green in CI on fix(chrome): give the template the Store, Reports and Flows entries gate-107 requires #192's merge.developmentskips E2E.🤖 Generated with Claude Code