chore(deps): relax the dexie pin now that nextcloud-vue loads it lazily - #765
Merged
Merged
Conversation
@conduction/nextcloud-vue 2.57.1 imports Dexie on first use of the offline database, so this app's main bundle no longer carries it. The exact pin and the Dependabot ignore existed to keep every app on one Dexie version because every page evaluated it; the pin goes back to a caret range and Dependabot may bump dexie here again.
Contributor
Quality Report — ConductionNL/keepiq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| test-l10n | ✅ | ||||
| format | ✅ | ||||
| check-l10n-js | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| composer | ✅ | ✅ 114/114 | |||
| npm | ✅ | ✅ 660/660 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ✅ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ✅ | ||||
| Newman | ✅ | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it on any branch from the Actions tab, or locally with npx playwright test. |
||||
| Hydra gates | ✅ |
Quality workflow — 2026-09-27 17:55 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relaxes the fleet dexie rule:
dexiegoes from the exact pin4.4.6back to^4.4.6, and the Dependabotignoreentry for dexie is removed. The resolved version stays 4.4.6, so nothing is reinstalled.Why now. The exact pin, the ignore and the "move all apps at once" rule existed because every app evaluated Dexie on every page, and Dexie throws "Two different versions of Dexie loaded in the same app" when two copies differ. Since 2026-09-27, every in-scope app is on
@conduction/nextcloud-vue2.57.1, which imports Dexie on first use of the offline database (nextcloud-vue#1266). The main and every-page bundles no longer carry it, so a Dexie difference between apps can no longer blank a page that doesn't use offline collection.What still holds. A page where two different apps both open the offline database still needs them on one Dexie version. That is rare, and why this is a caret range and not a free-for-all.
Changes: pkg 4.4.6 -> ^4.4.6 | dependabot: no dexie ignore
Verified: a real
npm ci --ignore-scriptsinstalls from the lockfile with the new range (npm refuses when package.json and the lockfile disagree), and.github/dependabot.ymlstill parses as YAML.🤖 Generated with Claude Code