fix(tests): two #706 tests that could not pass in CI - #717
Merged
rubenvdlinde merged 1 commit intoSep 15, 2026
Merged
Conversation
ConnectionsDeclarationTest read appinfo/info.xml with simplexml_load_file(). Nextcloud's lib/base.php nulls libxml's external entity loader, so that call returns false for a well-formed file whenever the suite runs under the Nextcloud bootstrap, which is every CI cell. It now parses the file contents as a string, as NextcloudFloorMatrixTest already does. The Integrations page e2e test looked a row up by an accessible name starting with the connection title, but each row's name starts with its "Select row" checkbox, so it found nothing while the page showed both rows. It now matches the row by its Connection cell.
Contributor
Quality Report — ConductionNL/keepiq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| test-l10n | ✅ | ||||
| format | ✅ | ||||
| check-l10n-js | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| composer | ✅ | ✅ 111/111 | |||
| npm | ✅ | ✅ 543/543 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ✅ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ❌ | ||||
| Newman | ✅ | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it on any branch from the Actions tab, or locally with npx playwright test. |
||||
| Hydra gates | ✅ |
Quality workflow — 2026-09-15 19:17 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two tests added in #706 could not pass in CI. Both were hidden until now, because the PHPUnit cells never got past installing integriq (fixed in ConductionNL/.github#779) and E2E does not run on push.
ConnectionsDeclarationTest::testTheFileNamesThisAppreadappinfo/info.xmlwithsimplexml_load_file(). Nextcloud'slib/base.phpnulls libxml's external entity loader, so under the Nextcloud bootstrap that call returns false for a well-formed file. It failed in all six PHPUnit cells withFailed asserting that false is not false.It now parses the file contents as a string, asNextcloudFloorMatrixTestalready does.integrations-page.spec.ts› lists the two declared connections looked a row up withgetByRole('row', { name: /^Breach check\b/ }). Each row's accessible name starts with its "Select row" checkbox, so the locator found 0 rows while the page showed both, which is visible in the failure screenshot. It now matches the row by its Connection cell. I also corrected the stale "written, not yet run" line in the spec header.Verified
ConnectionsDeclarationTestpasses locally (8 tests, 61 assertions). As a control, restoringsimplexml_load_file()with the entity loader nulled the waybase.phpdoes reproduces CI's exact failure on the same assertion.COMPOSER_PROCESS_TIMEOUT=0 composer check:strict: ALL CHECKS PASSED (PHPUnit 1,327 tests OK, 9 skipped).npm run formatandnpm run lint: pass, 0 lint errors.diff-check.sh --base origin/development: GREEN, gates PASS, 0 new findings.🤖 Generated with Claude Code