Skip to content

Feat sklearn pca50 - #113

Merged
tonyliang19 merged 3 commits into
mainfrom
feat-sklearn-pca50
Sep 4, 2026
Merged

tonyliang19 merged 3 commits into
mainfrom
feat-sklearn-pca50

Conversation

@tonyliang19

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI lite review requested due to automatic review settings September 4, 2026 09:35
@tonyliang19
tonyliang19 merged commit 74f48c1 into main Sep 4, 2026
1 check passed

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The RandomizedSearchCV pipeline change will break hyperparameter search unless parameter names are prefixed/stripped correctly (and Y is made 1D), which currently is not handled.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

This PR updates the sklearn method workflow/config to support iterating over multiple reduction modes (e.g., empty and pca50) and improves sklearn feature-selection training by standardizing features via a pipeline and expanding/aligning classifier definitions.

Changes:

  • Run sklearn training across all values in params.sklearn_reduction (e.g., empty, pca50) instead of treating reduction as a single value.
  • Update sklearn feature selection to scale features and adjust target shaping for estimator fitting.
  • Refactor/extend sklearn classifier metadata in feature selection and align real_data.config with the canonical selectFeature parameter name.
File summaries
File Description
subworkflows/methods/sklearn/main.nf Iterates over all configured sklearn reduction modes via Channel.fromList.
modules/sklearn/select_feature/resources/usr/bin/sklearn_select_features.py Adjusts final model fit target shaping.
modules/sklearn/select_feature/resources/usr/bin/run_random_search_cv.py Switches RandomizedSearchCV to a StandardScaler+estimator pipeline.
modules/sklearn/select_feature/resources/usr/bin/load_classifier_class.py Refactors classifier definitions and adds additional classifier options.
conf/real_data.config Fixes profile param name to selectFeature.
Review details
  • Files reviewed: 2/5 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants