Repository navigation
Feat sklearn pca50 - #113
Merged
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The RandomizedSearchCV pipeline change will break hyperparameter search unless parameter names are prefixed/stripped correctly (and Y is made 1D), which currently is not handled.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR updates the sklearn method workflow/config to support iterating over multiple reduction modes (e.g., empty and pca50) and improves sklearn feature-selection training by standardizing features via a pipeline and expanding/aligning classifier definitions.
Changes:
- Run sklearn training across all values in
params.sklearn_reduction(e.g.,empty,pca50) instead of treating reduction as a single value. - Update sklearn feature selection to scale features and adjust target shaping for estimator fitting.
- Refactor/extend sklearn classifier metadata in feature selection and align
real_data.configwith the canonicalselectFeatureparameter name.
File summaries
| File | Description |
|---|---|
| subworkflows/methods/sklearn/main.nf | Iterates over all configured sklearn reduction modes via Channel.fromList. |
| modules/sklearn/select_feature/resources/usr/bin/sklearn_select_features.py | Adjusts final model fit target shaping. |
| modules/sklearn/select_feature/resources/usr/bin/run_random_search_cv.py | Switches RandomizedSearchCV to a StandardScaler+estimator pipeline. |
| modules/sklearn/select_feature/resources/usr/bin/load_classifier_class.py | Refactors classifier definitions and adds additional classifier options. |
| conf/real_data.config | Fixes profile param name to selectFeature. |
Review details
- Files reviewed: 2/5 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.