Repository navigation
Platform selection + detection - #2
Merged
Merged
Conversation
- created UI page - created "Platform" installer KV
- improvements to follow
- includes the `setVisible()` addition
- `qt.py` was calling `init-repository` with only the submodules needed,
but then the actual `configure` command didn't specify those same
modules
- adding the `-submodules {submodules}` flag makes it so it only
compiles those which we need, avoiding compilation errors down the
line
because SOME PEOPLE don't check their linux pipelines
KKhanhH
pushed a commit
that referenced
this pull request
Oct 13, 2026
Platform selection + detection
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Centralized platform selection on its own separate page, can then be used anywhere else in the installer
Bumped
installer-frameworksubmodule to the newer version that includessetVisible()on GuiProxy, which we use when going down the updater routeFixed submodule compilation definition in
qt.py, without which the build was failing on my machine