Repository navigation
fix(malware-scan): scan committed vendor/, dist/ and build/ folders - #29
Merged
Merged
Conversation
SKIP_DIRS was applied in every mode, so tracked files under vendor/, dist/ or build/ were never scanned, including in CI and --all-branches. A live payload in SankalpTaru-Foundation/sankalptaru-website was missed: public/wp-content/plugins/seo-by-rank-math-pro/vendor/wp-media/plugin-family/webpack.config.js Git modes now scan every tracked path. The on-disk walk (--path) skips only untracked install/cache folders, and no longer skips vendor/dist/build. Co-Authored-By: Claude Opus 5.5 <[email protected]>
Member
Author
|
Added the vendor, dist, build and other folders under scan |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The scanner skipped every path under
vendor/,dist/andbuild/in all modes, including tracked files,--all-branches, and the CI workflow. This hid a live payload inSankalpTaru-Foundation/sankalptaru-website:public/wp-content/plugins/seo-by-rank-math-pro/vendor/wp-media/plugin-family/webpack.config.jsIt's the same campaign as the other files (
global.o=marker,_$_a291identifiers, char-127 decoder) and is present on 33 branches, includingdevelopandmain.Change
--staged,--all-branches) now scan every tracked path. A committedvendor/,dist/orbuild/folder is as attacker-writable assrc/.--path, used by the local sweep) still skips untracked install and cache folders (node_modules,.next,.nuxt,coverage,.venv/venv,__pycache__,.turbo,.cache), but no longer skipsvendor/,dist/orbuild/.malware-scan/README.mdupdated to match.Lockfiles,
*.mapand*.min.jsare still skipped in every mode (unchanged).Verification (text-only; no project code executed)
An independent
grepover each full checkout, with nothing skipped, finds the same four infected files and nothing else.After merge
mainSHA, not91a9f2f, which has this gap.cc-malware-scanskill must re-run the install block to get the fixed scanner.mainis still unprotected with no CODEOWNERS. Please have a second person review this PR before merging.🤖 Generated with Claude Code