test: add unit tests for analytics-range helpers - #900
Open
Ishaan-Gpt wants to merge 1 commit into
Open
Ishaan-Gpt wants to merge 1 commit into
Ishaan-Gpt wants to merge 1 commit into
Conversation
Covers parseRange (valid inputs pass through, invalid and undefined default to 30d) and rangeToDateBounds (7d, 30d, 90d spans, the all range starting at 2000-01-01, no mutation of the input date, fresh Date instances per call, and month-boundary subtraction). Part of Coder-s-OG-s#885.
6 of 11 tasks
|
This PR has had no activity for 7 days. Are you still working on it? If so, please push an update or leave a comment. Otherwise it will be labeled |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds unit tests for the analytics range helpers in
src/lib/maintainer/analytics-range.ts, covering one file from the #885 checklist as requested (one test file per PR).Type of Change
Related Issue
Related to #885
What was changed?
New file
src/lib/maintainer/analytics-range.test.ts(19 tests):parseRange: valid ranges (7d,30d,90d,all) pass through;undefined, empty, and invalid inputs fall back to30d.rangeToDateBounds:7d/30d/90dspan the right number of days ending atnow;allstarts at 2000-01-01; the input date is not mutated; each call returns freshDateinstances; day subtraction works across month boundaries.Screenshots
Not applicable (no UI changes).
Checklist
npx vitest run src/lib/maintainer/analytics-range.test.ts— 19/19 pass)npm run lintandprettier --checkpass on the new file;tsc --noEmitshows no new errors