Skip to content

Remove freebuff waiting room flag - #667

Closed
jahooma wants to merge 6689 commits into
mainfrom
jahooma/fix-freebuff-model-select
Closed

Remove freebuff waiting room flag#667
jahooma wants to merge 6689 commits into
mainfrom
jahooma/fix-freebuff-model-select

Conversation

@jahooma

@jahooma jahooma commented May 13, 2026

Copy link
Copy Markdown
Contributor

Removes the Freebuff waiting-room feature flag now that the session gate is permanently enabled. The server always starts admission, no longer emits disabled gate responses, and no longer fetches user email for the removed bypass path. CLI compatibility for older servers is preserved with the client-side disabled fallback, while docs and tests now describe the always-on session gate. Validated with package typechecks, focused Freebuff/session tests, chat completions tests, admission tests, and git diff --check.

jahooma and others added 30 commits April 22, 2026 16:33
Co-authored-by: James Grugett <[email protected]>
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Co-authored-by: Claude Opus 4.7 (1M context) <[email protected]>
github-actions Bot and others added 22 commits May 11, 2026 22:45
Set FREEBUFF_DEV_FORCE_LIMITED=true on localhost to make free-mode
country resolution return allowed=false, so the limited tier UX can be
exercised without a real geo block. Honored only when
NEXT_PUBLIC_CB_ENVIRONMENT === 'dev'; cache lookups are bypassed for
forced-limited requests so toggling the flag takes effect immediately.

Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
Limited tier only ever sees one model, so the multi-row picker chrome
(LIMITED section header, comparative tagline like "Most efficient",
"Pick a model to start" copy) read as filler. Fork a LimitedLandingPanel
that renders the model identity, data-collection caveat, session
counter, and a single bordered "Start session   Enter" CTA — confirm
gate rather than picker. Also strip the word "limited" from the session
counter and rate-limit copy across the waiting room and session-ended
banner so the tier name doesn't leak into user-facing text.

Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
@codebuff-team

Copy link
Copy Markdown
Contributor

This PR removes the FREEBUFF_WAITING_ROOM_ENABLED flag now that the session gate is always on, and the change itself looks clean and well-tested — the CLI-side compatibility fallback for older servers, the doc updates in docs/freebuff-waiting-room.md, and the removal of the [email protected] bypass and unused userEmail plumbing all read as a coherent, deliberate cleanup with corresponding test removals rather than blind churn.

However, per this mirror's scope rules, changes to web/ and packages/internal/ are not accepted here regardless of quality. The bulk of the substantive logic changes are in web/src/server/free-session/*, web/src/app/api/v1/freebuff/session/*, web/src/app/api/v1/chat/completions/*, and packages/internal/src/env-schema.ts — all out-of-scope paths for this repo. Only the CLI-side comment tweaks and doc changes would be in-scope, and those are cosmetic without the server-side change they describe.

If you want this ported, it needs to go through the private repo directly since the core of the diff can't land here. Nothing wrong with the work, just the wrong venue for the parts that matter.

@codebuff-team codebuff-team added bot:triaged Classified by the community triage bot pr:out-of-scope Touches paths the public mirror does not accept labels Aug 20, 2026
@victorxheng
victorxheng force-pushed the jahooma/fix-freebuff-model-select branch from 0a21aac to cb0bae6 Compare August 31, 2026 21:01
@github-actions

Copy link
Copy Markdown
Contributor

PR checks failed

A couple of things need fixing before this can be reviewed.
None of them are about the code itself.

This PR touches paths the public mirror does not accept.

  • packages/internal/src/env-schema.ts
  • web/src/app/api/v1/chat/completions/__tests__/completions.test.ts
  • web/src/app/api/v1/chat/completions/_post.ts
  • web/src/app/api/v1/freebuff/session/__tests__/session.test.ts
  • web/src/app/api/v1/freebuff/session/_handlers.ts
  • web/src/server/free-session/__tests__/public-api.test.ts
  • web/src/server/free-session/admission.ts
  • web/src/server/free-session/config.ts
  • web/src/server/free-session/public-api.ts

Backend, database, billing and deployment code is not part of
this repository. A change to those paths cannot be merged here
regardless of its quality. See CONTRIBUTING.md for the paths
that are in scope.


Edit the PR and this check re-runs automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot:triaged Classified by the community triage bot pr:out-of-scope Touches paths the public mirror does not accept

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants