Manchester | 26-SDC-Jul | Fithi-Teklom | Sprint 1 | Individual-shell-tools by Fithi-Teklom · Pull Request #567 · CodeYourFuture/Module-Tools

Fithi-Teklom · 2026-07-10T18:57:07Z

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

Completed the shell tools exercises covering ls, cat, wc, grep, sed, and awk.

What was added:

Implemented commands to list files and directories using ls.
Used cat to read and display file contents.
Used wc to count lines, words, and characters.
Used grep to search and filter text based on patterns.
Used sed for text replacement, deletion, and formatting transformations.
Used awk to extract columns, filter data, and perform calculations.

SlideGauge

A lot of files do not have trailing new line, add it please as well

SlideGauge · 2026-07-11T22:01:44Z

 # TODO: Write a command to output the contents of the helper-1.txt file inside the helper-files directory to the terminal.
 # The output of this command should be "Once upon a time...".
+
+cat helper-files/helper-1.txt


helper-files/ is a sibling of these folders, not a child.

SlideGauge · 2026-07-11T22:03:56Z

 # 2 I was tempted to take a bite of it.
 # 3 But this seemed like a bad idea...
+
+cat -n helper-files/helper-3.txt 


helper-files/ is a sibling of these folders, not a child.

SlideGauge · 2026-07-11T22:04:17Z

 # I was tempted to take a bite of it.
 # But this seemed like a bad idea...
+
+cat helper-files/*


helper-files/ is a sibling of these folders, not a child.

SlideGauge · 2026-07-11T22:04:41Z

 # TODO: Write a command to output the number of words in the file helper-files/helper-3.txt.
 # The output should include the number 19. The output should not include the number 92.
+
+wc -w helper-files/helper-3.txt


helper-files/ is a sibling of these folders, not a child.

SlideGauge · 2026-07-11T22:04:46Z

 # TODO: Write a command to output the number of lines in the file helper-files/helper-3.txt.
 # The output should include the number 3. The output should not include the number 19.
+
+wc -l helper-files/helper-3.txt


helper-files/ is a sibling of these folders, not a child.

SlideGauge · 2026-07-11T22:04:50Z

 #        3      19      92 ../helper-files/helper-3.txt
 #        5      30     151 total
+
+wc helper-files/*


helper-files/ is a sibling of these folders, not a child.

SlideGauge · 2026-07-11T22:05:37Z

 # TODO: Write a command to output every line in dialogue.txt said by the Doctor.
 # The output should contain 6 lines.
+
+grep "Doctor" dialogue.txt


Does it grabs only lines said by a doctor, not something like "Hello, Doctor!"?

SlideGauge · 2026-07-11T22:06:09Z

 # TODO: Write a command to output, for each `.txt` file in this directory, how many lines of dialogue the Doctor has.
 # The output should show that dialogue.txt contains 6 lines, dialogue-2.txt contains 2, and dialogue-3.txt contains 0.
+
+#grep -c "Doctor" *.txt


The line is commented, what was intended here to happen?

SlideGauge · 2026-07-11T22:06:54Z

 # TODO: Write a command to output input.txt replacing every occurrence of the string "We'll" with "We will".
 # The output should contain 11 lines.
+
+sed "We'll/We will/g"


How does it know which file to look into?

SlideGauge · 2026-07-11T22:07:17Z

 # TODO: Write a command which lists the files in the child-directory directory, one per line, sorted so that the most recently modified file is first.
 # The output should be a list of names in this order, one per line: helper-3.txt, helper-1.txt, helper-2.txt.

+# ls -1t child-directory


Why is this line commented?

SlideGauge · 2026-07-11T22:08:08Z

Could you address my comments please?

Fithi-Teklom · 2026-07-15T14:56:38Z

Could you address my comments please?

I have corrected the mistakes.

github-actions · 2026-07-15T14:57:17Z

Results of test:
Failed awk/script-01.sh, please check
Failed awk/script-02.sh, please check
Failed awk/script-03.sh, please check
Failed awk/script-04.sh, please check
Failed awk/script-05.sh, please check
Failed cat/script-01.sh, please check
Failed cat/script-02.sh, please check
Failed cat/script-03.sh, please check
Failed grep/script-01.sh, please check
Failed grep/script-02.sh, please check
Failed grep/script-03.sh, please check
Failed grep/script-04.sh, please check
Failed grep/script-05.sh, please check
Failed grep/script-06.sh, please check
Failed grep/script-07.sh, please check
Failed sed/script-01.sh, please check
Failed sed/script-02.sh, please check
Failed sed/script-03.sh, please check
Failed sed/script-04.sh, please check
Failed sed/script-05.sh, please check
Failed sed/script-06.sh, please check
Failed wc/script-01.sh, please check
Failed wc/script-02.sh, please check
Failed wc/script-03.sh, please check
You passed 4/28 tasks.

SlideGauge

Thanks for the update — the command logic is mostly correct now, and the awk/sed solutions show good understanding. However the tests still fail 24/28, and the root cause is the same for almost every script: file paths.

The README for this exercise says:

Before running a script you should cd into the directory it's in. You should write all of your scripts assuming they're running inside the directory they're saved in.

Paths like individual-shell-tools/awk/scores-table.txt only work when the script is run from the repository root — the tests run each script from its own folder. So:

in awk scripts: scores-table.txt
in grep scripts: dialogue.txt / *.txt
in sed scripts: input.txt
in cat/wc scripts: ../helper-files/... (this is what my earlier "sibling" comments meant — from inside cat/, go up one level with .., then into helper-files/)

Your ls scripts already do this correctly — that's exactly why they are the 4 that pass.

Also, most files are still missing the trailing newline I asked about in my previous review — please add it to all scripts.

Tip for checking your work before pushing: cd into each folder and run the script, e.g. cd individual-shell-tools/awk then ./script-01.sh — if it errors or prints the wrong thing there, the test will fail too.

SlideGauge · 2026-07-16T21:46:59Z


 # TODO: Write a command to output just the names of each player in `scores-table.txt`.
 # Your output should contain 6 lines, each with just one word on it.
+awk '{print $1}' individual-shell-tools/awk/scores-table.txt


🔴 This path only works when the script is run from the repository root. Per the README, scripts are run from their own directory — so this should just be scores-table.txt. The same applies to all of your awk, grep and sed scripts.

SlideGauge · 2026-07-16T21:46:59Z

 # TODO: Write a command to output the contents of the helper-1.txt file inside the helper-files directory to the terminal.
 # The output of this command should be "Once upon a time...".
+
+cat individual-shell-tools/helper-files/helper-1.txt


🔴 Closer than before, but this still assumes the script is run from the repository root. From inside the cat/ folder, you reach helper-files/ with ../helper-files/helper-1.txt — that's what "sibling" means: go up one level with .., then into the folder. Same fix for the other cat and wc scripts.

SlideGauge · 2026-07-16T21:46:59Z

 # TODO: Write a command to output every line in dialogue.txt said by the Doctor.
 # The output should contain 6 lines.
+
+grep "Doctor" individual-shell-tools/grep/dialogue.txt


🔴 This is the same issue I raised in my previous review: grep "Doctor" matches any line containing the word, so you get 8 lines — including Patient: Hello Doctor and the Spouse's line — while the task expects the 6 lines said by the Doctor. You already solved this in script-07 with ^Doctor: — use the same idea here.

SlideGauge · 2026-07-16T21:46:59Z

 # TODO: Write a command to output the name of every `.txt` file in this directory which contains a line of dialogue said by the Doctor.
 # The output should contain two filenames.
+
+grep -l "Doctor" individual-shell-tools/grep/*.txt


🟡 This happens to output the right two files, but a bit by luck — "Doctor" matches any mention of the word, not only lines the Doctor says. ^Doctor: (like your script-07) expresses exactly what the task asks and won't break if a file merely mentions the Doctor.

SlideGauge · 2026-07-16T21:46:59Z

 # TODO: Write a command to output just the names of each player along with the total of adding all of that player's scores.
 # Your output should contain 6 lines, each with one word and one number on it.
 # The first line should be "Ahmed 15". The second line should be "Basia 37"
+awk '{total=0; for(i=3;i<=NF;i++) total += $i; print $1, total}' individual-shell-tools/awk/scores-table.txt 


🟢 Nice work on the stretch goal — looping over the fields with for(i=3;i<=NF;i++) is exactly the right approach here.

SlideGauge · 2026-07-16T21:46:59Z

 # So line 6 which currently reads "37 Alisha" should instead read "Alisha 37".
 # The output should contain 11 lines.
+
+sed 's/^\([0-9][0-9]*\) \(.*\)$/\2 \1/' individual-shell-tools/sed/input.txt


🟢 Good use of capture groups to swap the number and the name — this is a tricky exercise and your regex is correct.

Fithi-Teklom added 3 commits July 8, 2026 14:55

finish ls exercises.

9516bb3

Complete cat exercises

c3d0b18

Complete the rest shell tools exercises.

689f6fd

Fithi-Teklom added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 10, 2026

This comment has been minimized.

Sign in to view

Fix what made it fail by uncommenting the command

51e231f

Fithi-Teklom added the 📅 Sprint 1 Assigned during Sprint 1 of this module label Jul 10, 2026

SlideGauge reviewed Jul 11, 2026

View reviewed changes

SlideGauge added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jul 11, 2026

Fithi-Teklom added 5 commits July 15, 2026 14:22

Add the correct path.

bd5d132

Add the correct path.

794f494

Correct path for the wc exercises

81d75b8

Add the correct path for grep exercises.

94e8f3f

Add the correct path.

6b78a4d

Fithi-Teklom added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 15, 2026

Fithi-Teklom removed the Reviewed Volunteer to add when completing a review with trainee action still to take. label Jul 15, 2026

SlideGauge suggested changes Jul 16, 2026

View reviewed changes

SlideGauge added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jul 17, 2026

Uh oh!

Uh oh!

Conversation

Fithi-Teklom commented Jul 10, 2026

Changelist

Uh oh!

This comment has been minimized.

SlideGauge left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SlideGauge commented Jul 11, 2026

Uh oh!

Fithi-Teklom commented Jul 15, 2026

Uh oh!

github-actions Bot commented Jul 15, 2026

Uh oh!

SlideGauge left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants